Fix memory leak of Ractor basket when sending to closed Ractor

peterzhu2118 · peterzhu2118 · commit d55c463d5638 · 2025-06-12T10:02:44.000-04:00
The following script leaks memory:

    r = Ractor.new { }
    r.value

    10.times do
      100_000.times do
        r.send(123)
      rescue Ractor::ClosedError
      end

      puts `ps -o rss= -p #{$$}`
    end

Before:

    18508
    25420
    32460
    40012
    47308
    54092
    61132
    68300
    75724
    83020

After:

    11432
    11432
    11432
    11432
    11432
    11432
    11432
    11432
    11432
    11688
diff --git a/ractor_sync.c b/ractor_sync.c
@@ -1197,6 +1197,7 @@ ractor_send_basket(rb_execution_context_t *ec, const struct ractor_port *rp, str
         RUBY_DEBUG_LOG("closed:%u@r%u", (unsigned int)ractor_port_id(rp), rb_ractor_id(rp->r));
 
         if (raise_on_error) {
+            ractor_basket_free(b);
             rb_raise(rb_eRactorClosedError, "The port was already closed");
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -1197,6 +1197,7 @@ ractor_send_basket(rb_execution_context_t ec, const struct ractor_port rp, str`
`1197`	`1197`	`RUBY_DEBUG_LOG("closed:%u@r%u", (unsigned int)ractor_port_id(rp), rb_ractor_id(rp->r));`
`1198`	`1198`
`1199`	`1199`	`if (raise_on_error) {`
	`1200`	`+ ractor_basket_free(b);`
`1200`	`1201`	`rb_raise(rb_eRactorClosedError, "The port was already closed");`
`1201`	`1202`	`}`
`1202`	`1203`	`}`