8000 Use a shared array for the `duparray` instruction · github/ruby@d46cd60 · GitHub
[go: up one dir, main page]

Skip to content

Commit d46cd60

Browse files
committed
Use a shared array for the duparray instruction
In this example code: ```ruby def foo [1, 2, 3, 4] end ``` The array literal uses a `duparray` instruction. Before this patch, `rb_ary_resurrect` would malloc and memcpy a new array buffer. This patch changes `rb_ary_resurrect` to use `ary_make_partial` so that the new array object shares the underlying buffer with the array stored in the instruction sequences. Before this patch, the new array object is not shared: ``` $ ruby -r objspace -e'p ObjectSpace.dump([1, 2, 3, 4])' "{\"address\":\"0x7fa2718372d0\", \"type\":\"ARRAY\", \"class\":\"0x7fa26f8b0010\", \"length\":4, \"memsize\":72, \"flags\":{\"wb_protected\":true}}\n" ``` After this patch: ``` $ ./ruby -r objspace -e'p ObjectSpace.dump([1, 2, 3, 4])' "{\"address\":\"0x7f9a76883638\", \"type\":\"ARRAY\", \"class\":\"0x7f9a758af900\", \"length\":4, \"shared\":true, \"references\":[\"0x7f9a768837c8\"], \"memsize\":40, \"flags\":{\"wb_protected\":true}}\n" ``` [Feature #15289] [ruby-core:90097] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66095 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
1 parent 0620c97 commit d46cd60

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

array.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2191,7 +2191,7 @@ rb_ary_dup(VALUE ary)
21912191
VALUE
21922192
rb_ary_resurrect(VALUE ary)
21932193
{
2194-
return rb_ary_new4(RARRAY_LEN(ary), RARRAY_CONST_PTR_TRANSIENT(ary));
2194+
return ary_make_partial(ary, rb_cArray, 0, RARRAY_LEN(ary));
21952195
}
21962196 3E9A

21972197
extern VALUE rb_output_fs;

0 commit comments

Comments
 (0)
0