[Bug #21159] module names should not be modifiable

nobu · nobu · commit 931ac960b6d1 · 2025-02-27T11:07:36.000+09:00
diff --git a/test/ruby/test_module.rb b/test/ruby/test_module.rb
@@ -3371,13 +3371,17 @@ def test_set_temporary_name
     m.const_set(:N, Module.new)
 
     assert_match(/\A#<Module:0x\h+>::N\z/, m::N.name)
-    m::N.set_temporary_name("fake_name_under_M")
+    m::N.set_temporary_name(name = "fake_name_under_M")
+    name.upcase!
     assert_equal("fake_name_under_M", m::N.name)
+    assert_raise(FrozenError) {m::N.name.upcase!}
     m::N.set_temporary_name(nil)
     assert_nil(m::N.name)
 
-    m.set_temporary_name("fake_name")
+    m.set_temporary_name(name = "fake_name")
+    name.upcase!
     assert_equal("fake_name", m.name)
+    assert_raise(FrozenError) {m.name.upcase!}
 
     m.set_temporary_name(nil)
     assert_nil m.name
diff --git a/variable.c b/variable.c
@@ -238,6 +238,8 @@ rb_mod_set_temporary_name(VALUE mod, VALUE name)
             rb_raise(rb_eArgError, "the temporary name must not be a constant path to avoid confusion");
         }
 
+        name = rb_str_new_frozen(name);
+
         // Set the temporary classpath to the given name:
         RCLASS_SET_CLASSPATH(mod, name, FALSE);
     }

Original file line number	Diff line number	Diff line change
`@@ -238,6 +238,8 @@ rb_mod_set_temporary_name(VALUE mod, VALUE name)`
`238`	`238`	`rb_raise(rb_eArgError, "the temporary name must not be a constant path to avoid confusion");`
`239`	`239`	`}`
`240`	`240`
	`241`	`+ name = rb_str_new_frozen(name);`
	`242`	`+`
`241`	`243`	`// Set the temporary classpath to the given name:`
`242`	`244`	`RCLASS_SET_CLASSPATH(mod, name, FALSE);`
`243`	`245`	`}`