8000 Fix crash in TCPSocket.open · github/ruby@7e093fb · GitHub
[go: up one dir, main page]

Skip to content

Commit 7e093fb

Browse files
lukejahnkek0kubun
authored andcommitted
Fix crash in TCPSocket.open
Fix segfault crash observable with TCPSocket.open(nil, nil)
1 parent e580145 commit 7e093fb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ext/socket/ipsocket.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ init_fast_fallback_inetsock_internal(VALUE v)
593593
arg->getaddrinfo_shared->notify = hostname_resolution_notifier;
594594

595595
arg->getaddrinfo_shared->node = arg->hostp ? ruby_strdup(arg->hostp) : NULL;
596-
arg->getaddrinfo_shared->service = ruby_strdup(arg->portp);
596+
arg->getaddrinfo_shared->service = arg->portp ? ruby_strdup(arg->portp) : NULL;
597597
arg->getaddrinfo_shared->refcount = arg->family_size + 1;
598598

599599
for (int i = 0; i < arg->family_size; i++) {

0 commit comments

Comments
 (0)
0