Fix coverage measurement for negative line numbers

mame · mike-bourgeous · byroot · mame · commit 0d6263bd4163 · 2025-04-09T23:45:54.000+09:00
Fixes [Bug #21220]

Co-Authored-By: Mike Bourgeous &lt;mike@mikebourgeous.com&gt;
Co-Authored-By: Jean Boussier &lt;jean.boussier@gmail.com&gt;
diff --git a/compile.c b/compile.c
@@ -10746,7 +10746,7 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *const no
         if (nd_fl_newline(node)) {
             int event = RUBY_EVENT_LINE;
             ISEQ_COMPILE_DATA(iseq)->last_line = line;
-            if (ISEQ_COVERAGE(iseq) && ISEQ_LINE_COVERAGE(iseq)) {
+            if (line > 0 && ISEQ_COVERAGE(iseq) && ISEQ_LINE_COVERAGE(iseq)) {
                 event |= RUBY_EVENT_COVERAGE_LINE;
             }
             ADD_TRACE(ret, event);
diff --git a/prism_compile.c b/prism_compile.c
@@ -8597,7 +8597,7 @@ pm_compile_node(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const ret,
         int event = RUBY_EVENT_LINE;
 
         ISEQ_COMPILE_DATA(iseq)->last_line = lineno;
-        if (ISEQ_COVERAGE(iseq) && ISEQ_LINE_COVERAGE(iseq)) {
+        if (lineno > 0 && ISEQ_COVERAGE(iseq) && ISEQ_LINE_COVERAGE(iseq)) {
             event |= RUBY_EVENT_COVERAGE_LINE;
         }
         PUSH_TRACE(ret, event);
diff --git a/test/coverage/test_coverage.rb b/test/coverage/test_coverage.rb
@@ -192,6 +192,23 @@ def test_eval_coverage
     end;
   end
 
+  def test_eval_negative_lineno
+    assert_in_out_err(ARGV, <<-"end;", ["[1, 1, 1]"], [])
+      Coverage.start(eval: true, lines: true)
+
+      eval(<<-RUBY, TOPLEVEL_BINDING, "test.rb", -2)
+      p # -2 # Not subject to measurement
+      p # -1 # Not subject to measurement
+      p #  0 # Not subject to measurement
+      p #  1 # Subject to measurement
+      p #  2 # Subject to measurement
+      p #  3 # Subject to measurement
+      RUBY
+
+      p Coverage.result["test.rb"][:lines]
+    end;
+  end
+
   def test_coverage_supported
     assert Coverage.supported?(:lines)
     assert Coverage.supported?(:oneshot_lines)
diff --git a/thread.c b/thread.c
@@ -5662,6 +5662,7 @@ update_line_coverage(VALUE data, const rb_trace_arg_t *trace_arg)
         VALUE lines = RARRAY_AREF(coverage, COVERAGE_INDEX_LINES);
         if (lines) {
             long line = rb_sourceline() - 1;
+            VM_ASSERT(line >= 0);
             long count;
             VALUE num;
             void rb_iseq_clear_event_flags(const rb_iseq_t *iseq, size_t pos, rb_event_flag_t reset);

Original file line number	Diff line number	Diff line change
`@@ -10746,7 +10746,7 @@ iseq_compile_each0(rb_iseq_t iseq, LINK_ANCHOR const ret, const NODE *const no`
`10746`	`10746`	`if (nd_fl_newline(node)) {`
`10747`	`10747`	`int event = RUBY_EVENT_LINE;`
`10748`	`10748`	`ISEQ_COMPILE_DATA(iseq)->last_line = line;`
`10749`		`- if (ISEQ_COVERAGE(iseq) && ISEQ_LINE_COVERAGE(iseq)) {`
	`10749`	`+ if (line > 0 && ISEQ_COVERAGE(iseq) && ISEQ_LINE_COVERAGE(iseq)) {`
`10750`	`10750`	`event \|= RUBY_EVENT_COVERAGE_LINE;`
`10751`	`10751`	`}`
`10752`	`10752`	`ADD_TRACE(ret, event);`
Original file line number	Diff line number	Diff line change
`@@ -8597,7 +8597,7 @@ pm_compile_node(rb_iseq_t iseq, const pm_node_t node, LINK_ANCHOR *const ret,`
`8597`	`8597`	`int event = RUBY_EVENT_LINE;`
`8598`	`8598`
`8599`	`8599`	`ISEQ_COMPILE_DATA(iseq)->last_line = lineno;`
`8600`		`- if (ISEQ_COVERAGE(iseq) && ISEQ_LINE_COVERAGE(iseq)) {`
	`8600`	`+ if (lineno > 0 && ISEQ_COVERAGE(iseq) && ISEQ_LINE_COVERAGE(iseq)) {`
`8601`	`8601`	`event \|= RUBY_EVENT_COVERAGE_LINE;`
`8602`	`8602`	`}`
`8603`	`8603`	`PUSH_TRACE(ret, event);`