8000 Display text wrong · Issue #288 · github/relative-time-element · GitHub
[go: up one dir, main page]
Skip to content

Display text wrong #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Leo01234 opened this issue Jul 31, 2024 · 2 comments
Closed

Display text wrong #288

Leo01234 opened this issue Jul 31, 2024 · 2 comments

Comments

@Leo01234
Copy link
Leo01234 commented Jul 31, 2024 •
edited
Loading

It should be something like "1 month ago", but it writes "yesterday".

Edit:

I just notice #281, but it seems not fixed.
@Gr3q Gr3q mentioned this issue Jul 31, 2024
Closed
@keithamus
Copy link
Contributor
keithamus commented Jul 31, 2024 •
edited
Loading

Can you please make a PR with a failing test? We have a bunch of tests in a file that look like this:

relative-time-element/test/relative-time.js

Lines 1806 to 1812 in 15ca61e

{
reference: '2023-03-23T12:03:00.000Z',
datetime: '2023-03-21T16:03:00.000Z',
format: 'relative',
tense: 'past',
expected: '2 days ago',
},

If you copy that object and add a new one right below it with the values tweaked (reference set to todays date, datetime set to the datetime attribute on the failing instance) to represent the expected output, and we can see if it fails. If it does fail we can look at a fix.

@aprendendofelipe
Copy link

It's not a problem with relative-time-element. GitHub is not using version 4.4.2 yet.

See primer/react#4803

@Leo01234 Leo01234 closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@keithamus @Leo01234 @aprendendofelipe
0