Merge pull request #242 from idlewan/year-setter-typo

jonrohan · web-flow · commit e46316c4cc55 · 2023-01-12T09:31:27.000-08:00
Year setter typo
diff --git a/src/relative-time-element.ts b/src/relative-time-element.ts
@@ -258,7 +258,7 @@ export default class RelativeTimeElement extends HTMLElement implements Intl.Dat
   }
 
   set year(value: 'numeric' | '2-digit' | undefined) {
-    this.setAttribute('day', value || '')
+    this.setAttribute('year', value || '')
   }
 
   get timeZoneName() {
diff --git a/test/relative-time.js b/test/relative-time.js
@@ -384,7 +384,7 @@ suite('relative-time', function () {
     time.setAttribute('lang', 'en-US')
     time.setAttribute('format', '')
     await Promise.resolve()
-    assert.equal(time.shadowRoot.textContent, 'on Jan 10')
+    assert.equal(time.shadowRoot.textContent, 'on Jan 10, 2022')
   })
 
   const esLangSupport = (function () {

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ export default class RelativeTimeElement extends HTMLElement implements Intl.Dat`
`258`	`258`	`}`
`259`	`259`
`260`	`260`	`set year(value: 'numeric' \| '2-digit' \| undefined) {`
`261`		`- this.setAttribute('day', value \|\| '')`
	`261`	`+ this.setAttribute('year', value \|\| '')`
`262`	`262`	`}`
`263`	`263`
`264`	`264`	`get timeZoneName() {`