Obsolete NoteCollection.Remove() overload that do not require Signature parameters

nulltoken · nulltoken · commit cfbec61e124c · 2015-08-18T11:23:42.000+02:00
diff --git a/LibGit2Sharp.Tests/NoteFixture.cs b/LibGit2Sharp.Tests/NoteFixture.cs
@@ -279,7 +279,9 @@ public void CanRemoveANoteWithSignatureFromConfig()
 
                 Assert.NotEmpty(notes);
 
-                repo.Notes.Remove(commit.Id, repo.Notes.DefaultNamespace);
+                Signature signature = repo.Config.BuildSignature(DateTimeOffset.Now);
+
+                repo.Notes.Remove(commit.Id, signature, signature, repo.Notes.DefaultNamespace);
 
                 Assert.Empty(notes);
 
diff --git a/LibGit2Sharp/NoteCollection.cs b/LibGit2Sharp/NoteCollection.cs
@@ -211,6 +211,7 @@ public virtual Note Add(ObjectId targetId, string message, Signature author, Sig
         /// </summary>
         /// <param name="targetId">The target <see cref="ObjectId"/>, for which the note will be created.</param>
         /// <param name="namespace">The namespace on which the note will be removed. It can be either a canonical namespace or an abbreviated namespace ('refs/notes/myNamespace' or just 'myNamespace').</param>
+        [Obsolete("This method will be removed in the next release. Please use Remove(ObjectId, Signature, Signature, string) instead.")]
         public virtual void Remove(ObjectId targetId, string @namespace)
         {
             Signature author = repo.Config.BuildSignatureOrThrow(DateTimeOffset.Now);

Original file line number	Diff line number	Diff line change
`@@ -211,6 +211,7 @@ public virtual Note Add(ObjectId targetId, string message, Signature author, Sig`
`211`	`211`	`/// </summary>`
`212`	`212`	`/// <param name="targetId">The target <see cref="ObjectId"/>, for which the note will be created.</param>`
`213`	`213`	`/// <param name="namespace">The namespace on which the note will be removed. It can be either a canonical namespace or an abbreviated namespace ('refs/notes/myNamespace' or just 'myNamespace').</param>`
	`214`	`+ [Obsolete("This method will be removed in the next release. Please use Remove(ObjectId, Signature, Signature, string) instead.")]`
`214`	`215`	`public virtual void Remove(ObjectId targetId, string @namespace)`
`215`	`216`	`{`
`216`	`217`	`Signature author = repo.Config.BuildSignatureOrThrow(DateTimeOffset.Now);`