github
diff --git a/‎pkg/toolsets/toolsets.go‎
Lines changed: 4 additions & 4 deletions b/‎pkg/toolsets/toolsets.go‎
Lines changed: 4 additions & 4 deletions
diff --git a/‎pkg/toolsets/toolsets_test.go‎
Lines changed: 2 additions & 2 deletions b/‎pkg/toolsets/toolsets_test.go‎
Lines changed: 2 additions & 2 deletions
@@ -204,13 +204,13 @@ func (tg *ToolsetGroup) IsEnabled(name string) bool {
 }
 
 type EnableToolsetsOptions struct {
-	IgnoreUnknown bool
+	ErrorOnUnknown bool
 }
 
 func (tg *ToolsetGroup) EnableToolsets(names []string, options *EnableToolsetsOptions) error {
 	if options == nil {
 		options = &EnableToolsetsOptions{
-			IgnoreUnknown: true,
+			ErrorOnUnknown: false,
 		}
 	}
 
@@ -221,15 +221,15 @@ func (tg *ToolsetGroup) EnableToolsets(names []string, options *EnableToolsetsOp
 			break
 		}
 		err := tg.EnableToolset(name)
-		if err != nil && !options.IgnoreUnknown {
+		if err != nil && options.ErrorOnUnknown {
 			return err
 		}
 	}
 	// Do this after to ensure all toolsets are enabled if "all" is present anywhere in list
 	if tg.everythingOn {
 		for name := range tg.Toolsets {
 			err := tg.EnableToolset(name)
-			if err != nil && !options.IgnoreUnknown {
+			if err != nil && options.ErrorOnUnknown {
 				return err
 			}
 		}
 
@@ -154,13 +154,13 @@ func TestEnableToolsets(t *testing.T) {
 	}
 
 	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{
-		IgnoreUnknown: true,
+		ErrorOnUnknown: false,
 	})
 	if err != nil {
 		t.Errorf("Expected no error when ignoring unknown toolsets, got: %v", err)
 	}
 
-	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{IgnoreUnknown: false})
+	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{ErrorOnUnknown: true})
 	if err == nil {
 		t.Error("Expected error when enabling list with non-existent toolset")
 	}
Original file line number	Diff line number	Diff line change
`@@ -204,13 +204,13 @@ func (tg *ToolsetGroup) IsEnabled(name string) bool {`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`type EnableToolsetsOptions struct {`
`207`		`- IgnoreUnknown bool`
	`207`	`+ ErrorOnUnknown bool`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`func (tg ToolsetGroup) EnableToolsets(names []string, options EnableToolsetsOptions) error {`
`211`	`211`	`if options == nil {`
`212`	`212`	`options = &EnableToolsetsOptions{`
`213`		`- IgnoreUnknown: true,`
	`213`	`+ ErrorOnUnknown: false,`
`214`	`214`	`}`
`215`	`215`	`}`
`216`	`216`
`@@ -221,15 +221,15 @@ func (tg ToolsetGroup) EnableToolsets(names []string, options EnableToolsetsOp`
`221`	`221`	`break`
`222`	`222`	`}`
`223`	`223`	`err := tg.EnableToolset(name)`
`224`		`- if err != nil && !options.IgnoreUnknown {`
	`224`	`+ if err != nil && options.ErrorOnUnknown {`
`225`	`225`	`return err`
`226`	`226`	`}`
`227`	`227`	`}`
`228`	`228`	`// Do this after to ensure all toolsets are enabled if "all" is present anywhere in list`
`229`	`229`	`if tg.everythingOn {`
`230`	`230`	`for name := range tg.Toolsets {`
`231`	`231`	`err := tg.EnableToolset(name)`
`232`		`- if err != nil && !options.IgnoreUnknown {`
	`232`	`+ if err != nil && options.ErrorOnUnknown {`
`233`	`233`	`return err`
`234`	`234`	`}`
`235`	`235`	`}`
Original file line number	Diff line number	Diff line change
`@@ -154,13 +154,13 @@ func TestEnableToolsets(t *testing.T) {`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{`
`157`		`- IgnoreUnknown: true,`
	`157`	`+ ErrorOnUnknown: false,`
`158`	`158`	`})`
`159`	`159`	`if err != nil {`
`160`	`160`	`t.Errorf("Expected no error when ignoring unknown toolsets, got: %v", err)`
`161`	`161`	`}`
`162`	`162`
`163`		`- err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{IgnoreUnknown: false})`
	`163`	`+ err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{ErrorOnUnknown: true})`
`164`	`164`	`if err == nil {`
`165`	`165`	`t.Error("Expected error when enabling list with non-existent toolset")`
`166`	`166`	`}`