Add test cases for non-stream field accesses and methods before and after pipe operations

Napalys · Napalys · commit b6b64d2194f0 · 2025-05-21T11:41:24.000+02:00
diff --git a/javascript/ql/test/query-tests/Quality/UnhandledStreamPipe/test.expected b/javascript/ql/test/query-tests/Quality/UnhandledStreamPipe/test.expected
@@ -9,3 +9,8 @@
 | test.js:116:5:116:21 | stream.pipe(dest) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
 | test.js:125:5:125:26 | getStre ... e(dest) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
 | test.js:143:5:143:62 | stream. ... itable) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:171:5:171:50 | notStre ... itable) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:175:5:175:39 | notStre ... itable) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:179:17:179:40 | notStre ... itable) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:183:17:183:40 | notStre ... itable) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:193:5:193:32 | copyStr ... nation) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
diff --git a/javascript/ql/test/query-tests/Quality/UnhandledStreamPipe/test.js b/javascript/ql/test/query-tests/Quality/UnhandledStreamPipe/test.js
@@ -166,4 +166,30 @@ function test() {
     const notStream = getNotAStream();
     notStream.pipe(arg1, arg2, arg3);
   }
+  { // Usage of pipe after a non-stream method
+    const notStream = getNotAStream();
+    notStream.nonStreamMethodName().pipe(writable); // $SPURIOUS:Alert
+  }
+  { // Usage of pipe after a non-stream member
+    const notStream = getNotAStream();
+    notStream.someMember.pipe(writable); // $SPURIOUS:Alert
+  }
+  { // Member access on a non-stream after pipe
+    const notStream = getNotAStream();
+    const val = notStream.pipe(writable).someMember; // $SPURIOUS:Alert
+  }
+  { // Member access on a stream after pipe
+    const notStream = getNotAStream();
+    const val = notStream.pipe(writable).readable; // $Alert
+  }
+  { // Method access on a non-stream after pipe
+    const notStream = getNotAStream();
+    const val = notStream.pipe(writable).someMethod();
+  }
+  { // Pipe on fs readStream
+    const fs = require('fs');
+    const stream = fs.createReadStream('file.txt');
+    const copyStream = stream;
+    copyStream.pipe(destination); // $Alert
+  }
 }
