Merge pull request #15211 from owen-mc/go/redefine-successfully-extracted-files

owen-mc · web-flow · commit 697aa609f452 · 2024-01-03T16:07:09.000Z
Go: report any extracted file as successfully extracted
diff --git a/go/ql/lib/change-notes/2024-01-02-go-successfully-extracted.md b/go/ql/lib/change-notes/2024-01-02-go-successfully-extracted.md
@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* The diagnostic query `go/diagnostics/successfully-extracted-files`, and therefore the Code Scanning UI measure of scanned Go files, now considers any Go file seen during extraction, even one with some errors, to be extracted / scanned.
diff --git a/go/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql b/go/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql
@@ -1,15 +1,13 @@
 /**
  * @id go/diagnostics/successfully-extracted-files
- * @name Successfully analyzed files
- * @description List all files that were successfully extracted.
+ * @name Extracted files
+ * @description List all files that were extracted.
  * @kind diagnostic
  * @tags successfully-extracted-files
  */
 
 import go
 
 from File f
-where
-  not exists(Error e | e.getFile() = f) and
-  exists(f.getRelativePath())
+where exists(f.getRelativePath())
 select f, ""
diff --git a/go/ql/test/query-tests/Diagnostics/SuccessfullyExtractedFiles.expected b/go/ql/test/query-tests/Diagnostics/SuccessfullyExtractedFiles.expected
@@ -1,2 +1,4 @@
 | ../../go.mod:0:0:0:0 | ../../go.mod |  |
+| badimport.go:0:0:0:0 | badimport.go |  |
+| type.go:0:0:0:0 | type.go |  |
 | util.go:0:0:0:0 | util.go |  |

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +category: minorAnalysis
 +---
 +* The diagnostic query `go/diagnostics/successfully-extracted-files`, and therefore the Code Scanning UI measure of scanned Go files, now considers any Go file seen during extraction, even one with some errors, to be extracted / scanned.