Actions: resolve TODOs from diff-informed patch

asgerf · asgerf · commit 43325f40aa9e · 2025-01-22T13:33:57.000+01:00
diff --git a/actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll b/actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll
@@ -72,9 +72,7 @@ private module ActionsMutableRefCheckoutConfig implements DataFlow::ConfigSig {
   }
 
   predicate observeDiffInformedIncrementalMode() {
-    // TODO(diff-informed): Manually verify if config can be diff-informed.
-    // actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll:238: Flow call outside 'select' clause
-    none()
+    none() // The query does not use the PathGraph from this data flow config
   }
 }
 
@@ -129,9 +127,7 @@ private module ActionsSHACheckoutConfig implements DataFlow::ConfigSig {
   }
 
   predicate observeDiffInformedIncrementalMode() {
-    // TODO(diff-informed): Manually verify if config can be diff-informed.
-    // actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll:273: Flow call outside 'select' clause
-    none()
+    none() // The query does not use the PathGraph from this data flow config
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -72,9 +72,7 @@ private module ActionsMutableRefCheckoutConfig implements DataFlow::ConfigSig {`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`predicate observeDiffInformedIncrementalMode() {`
`75`		`- // TODO(diff-informed): Manually verify if config can be diff-informed.`
`76`		`- // actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll:238: Flow call outside 'select' clause`
`77`		`- none()`
	`75`	`+ none() // The query does not use the PathGraph from this data flow config`
`78`	`76`	`}`
`79`	`77`	`}`
`80`	`78`
`@@ -129,9 +127,7 @@ private module ActionsSHACheckoutConfig implements DataFlow::ConfigSig {`
`129`	`127`	`}`
`130`	`128`
`131`	`129`	`predicate observeDiffInformedIncrementalMode() {`
`132`		`- // TODO(diff-informed): Manually verify if config can be diff-informed.`
`133`		`- // actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll:273: Flow call outside 'select' clause`
`134`		`- none()`
	`130`	`+ none() // The query does not use the PathGraph from this data flow config`
`135`	`131`	`}`
`136`	`132`	`}`
`137`	`133`