JS: Explain use of monotonicAggregates

asgerf · asgerf · commit 1f308ee47ab0 · 2025-05-02T13:22:27.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/internal/paths/PathExprResolver.qll b/javascript/ql/lib/semmle/javascript/internal/paths/PathExprResolver.qll
@@ -65,6 +65,7 @@ module ResolveExpr<exprSig/1 shouldResolveExpr> {
       or
       exists(PathConcatenation join |
         node = TValueNode(join) and
+        // Note: 'monotonicAggregates' above lets us use recursion in the last clause of this aggregate
         result =
           strictconcat(int n, EarlyStageNode child, string sep |
             child = TValueNode(join.getOperand(n)) and sep = join.getSeparator()
