This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Removed IConnection.Repositories.
#1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `IConnection.Repositories` and `IConnectionManager.RefreshRepositories` and replaced them with `LocalRepositories` which acts as a central place to find known repositories. As part of this, also added `IReadOnlyObservableCollection` and `ObservableCollectionEx` because the BCL's `ReadOnlyObservableCollection` sucks. Made `TrackingCollection` implement `IReadOnlyObservableCollection`.
This was referenced Oct 20, 2017
shana
reviewed
Oct 23, 2017
| /// Explorer. | ||
| /// </remarks> | ||
| [Export(typeof(ILocalRepositories))] | ||
| public class LocalRepositories : ILocalRepositories |
There was a problem hiding this comment.
I don't this this implementation should be here, this will bring all the Rx dependencies in when there's no need for it. The reason this was in ConnectionManager to begin with was meant to be light weight and require minimal dependencies. Perhaps GitHub.Exports or some other place would be better? Maybe even GitHub.VisualStudio?
There was a problem hiding this comment.
Isn't the fact that its export is in GitHub.Exports good enough? If you look at some of our models, e.g. PullRequestModel - that is defined in GitHub.App with its interface in GitHub.Exports meaning that it's available to the non-rx parts of the extension. Rx shouldn't be loaded until a type that references rx is loaded, right?
Following advice by @shana.
…local-repositories
…local-repositories Conflicts: src/GitHub.VisualStudio/Services/ConnectionManager.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
IConnection.RepositoriesandIConnectionManager.RefreshRepositoriesand replaced them withLocalRepositorieswhich acts as a central place to find known repositories.As part of this, also added
IReadOnlyObservableCollectionandObservableCollectionExbecause the BCL'sReadOnlyObservableCollectionsucks. MadeTrackingCollectionimplementIReadOnlyObservableCollection.