8000 Automatically update this extension doesn't appear to work · Issue #877 · github/VisualStudio · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Automatically update this extension doesn't appear to work #877

Closed
jcansdale opened this issue Feb 21, 2017 · 10 comments
Closed

Automatically update this extension doesn't appear to work #877

jcansdale opened this issue Feb 21, 2017 · 10 comments
Labels
bug installer

Comments

@jcansdale
Copy link
Collaborator
jcansdale commented Feb 21, 2017 •
edited
Loading
  • Visual Studio 2017 RC4
  1. Ensure that 'Automatically update this extension' is enabled:

image

  1. Check there is an update available:

image

  1. Restart Visual Studio

Expected Behavior

The pending 'GitHub Extension for Visual Studio' would now be installed.

Actual Behavior

The 'GitHub Extension for Visual Studio' still appears under 'Updates' and hasn't been automatically updated.

Note

This extension has AllUsers=true, which I believe is a requirement when packging with the Visual Studio installer? When AllUsers=false, auto updates seem to work fine.
@jcansdale jcansdale added the bug label Feb 21, 2017
@jcansdale
Copy link
Collaborator Author

I've attempted to repro locally using the following steps.

  1. Extract ZIP to c:\AutoUpdateReproAllUsers
    AutoUpdateReproAllUsers.zip

  2. Add new Extension Gallerie at c:\AutoUpdateReproAllUsers\AllUsers.rss
    image

  3. Install the 2.1.1.4 version of the extension:
    image

  4. Restart Visual Studio (extension installs with VSIXInstaller).

  5. Extension is now visible in list with 'Automatically update this extension' checked.
    image

  6. Version 2.2.0.5 appears in list as available update.
    image

  7. Restart Visual Studio.

  8. Version 2.2.0.5 remains in list of available updates and hasn't been automatically updated 😭.

Please let me know if we're doing wrong!

@jcansdale jcansdale mentioned this issue Feb 21, 2017
Closed
@tinaschrepfer
Copy link
tinaschrepfer commented Feb 22, 2017 •
edited
Loading

Because VSIXes in VS 2017 are installed by the VS installer setup engine, you must have all instances of VS (all versions) closed for auto-update to work. Auto-update kicks in every night and tries to update, but if you have VS open, then it will fail to do so. We're working on improving the messaging of this for a future update so users will know that they have to shut down VS.

If you want to test this out yourself, you can shut down VS, go to Task Scheduler and run the VSIX Auto Update task manually.

@jcansdale jcansdale mentioned this issue Feb 22, 2017
Merged
@jcansdale
Copy link
Collaborator Author

Oh wow, thanks for the quick response!

Sure enough it's there:
image

I never would have guessed. 😄

@jcansdale
Copy link
Collaborator Author

@tinaschrepfer, Great, thanks for letting us know!

Is seems automatic updates do work, I was just being impatient. 😉

@grokys grokys reopened this Mar 13, 2017
@grokys
Copy link
Contributor
grokys commented Mar 13, 2017

@tinaschrepfer I installed VS2017 at launch last week and my version of GHfVS still hasn't been updated - it's still at 2.1.1.4:

image

I enabled Task Scheduler history and I can see that the auto-update task is being run:

image

Is there any more information I can provide to try and work out why this isn't updating?

@grokys
Copy link
Contributor
grokys commented Mar 20, 2017

I just noticed that the update task in the Task Scheduler is for VS2015, not 2017. That would explain it:

image

Any idea how that happened, and how I can fix it?

@tinaschrepfer
Copy link

@grokys, are you saying that the 2017 task scheduler is not present? When I go to VS in Task Scheduler, I see there's 2 versions, VSIX Auto Update 14 and VSIX Auto update 15.0.26220.0. Is this not what you see?

8000
@grokys
Copy link
Contributor
grokys commented Mar 20, 2017

@tinaschrepfer yep, exactly - when I go to VS in Task Scheduler, there's only the single entry as shown in the screenshot above. VS2015 and 2017 are installed on this machine.

@tinaschrepfer
Copy link

Ah, it looks like we only create the auto update task if you've installed any extension using VSIXInstaller.exe. Prior to VS2017, GitHub was installed as part of the product using VSIXInstaller.exe. But since then we've switched to directly use the VS installer setup engine. I've created a bug to track this gap in behavior. For now, you'll have to manually update GitHub extension initially, and then the auto update task will be created. Also remember that for auto update to work, you'll need to shut down all instances of VS. Sorry about this!

@grokys
Copy link
Contributor
grokys commented Dec 11, 2017

I think this is now fixed, closing.

@grokys grokys closed this as completed Dec 11, 2017
@knom knom mentioned this issue May 30, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug installer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grokys @jcansdale @tinaschrepfer
0