-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Automatically update this extension doesn't appear to work #877
Comments
I've attempted to repro locally using the following steps.
Please let me know if we're doing wrong! |
Because VSIXes in VS 2017 are installed by the VS installer setup engine, you must have all instances of VS (all versions) closed for auto-update to work. Auto-update kicks in every night and tries to update, but if you have VS open, then it will fail to do so. We're working on improving the messaging of this for a future update so users will know that they have to shut down VS. If you want to test this out yourself, you can shut down VS, go to Task Scheduler and run the VSIX Auto Update task manually. |
@tinaschrepfer, Great, thanks for letting us know! Is seems automatic updates do work, I was just being impatient. 😉 |
@tinaschrepfer I installed VS2017 at launch last week and my version of GHfVS still hasn't been updated - it's still at 2.1.1.4: I enabled Task Scheduler history and I can see that the auto-update task is being run: Is there any more information I can provide to try and work out why this isn't updating? |
@grokys, are you saying that the 2017 task scheduler is not present? When I go to VS in Task Scheduler, I see there's 2 versions, VSIX Auto Update 14 and VSIX Auto update 15.0.26220.0. Is this not what you see? |
@tinaschrepfer yep, exactly - when I go to VS in Task Scheduler, there's only the single entry as shown in the screenshot above. VS2015 and 2017 are installed on this machine. |
Ah, it looks like we only create the auto update task if you've installed any extension using VSIXInstaller.exe. Prior to VS2017, GitHub was installed as part of the product using VSIXInstaller.exe. But since then we've switched to directly use the VS installer setup engine. I've created a bug to track this gap in behavior. For now, you'll have to manually update GitHub extension initially, and then the auto update task will be created. Also remember that for auto update to work, you'll need to shut down all instances of VS. Sorry about this! |
I think this is now fixed, closing. |
Uh oh!
There was an error while loading. Please reload this page.
Expected Behavior
The pending 'GitHub Extension for Visual Studio' would now be installed.
Actual Behavior
The 'GitHub Extension for Visual Studio' still appears under 'Updates' and hasn't been automatically updated.
Note
This extension has
AllUsers=true
, which I believe is a requirement when packging with the Visual Studio installer? WhenAllUsers=false
, auto updates seem to work fine.The text was updated successfully, but these errors were encountered: