8000 bindingRedirects can become out of sync with installed extension · Issue #1217 · github/VisualStudio · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
bindingRedirects can become out of sync with installed extension #1217
Closed
@jcansdale

Description

@jcansdale
  • GitHub Extension for Visual Studio version: v2.3.1.30 (iirc)
  • Visual Studio version: 2017 15.3

There have been a few instances where it looks like the devenv.exe.config file has become out of whack with the installed version of the extension. This has been a problem because we use ProvideCodeBase / ProvideBindingRedirection attributes to ensure that our assemblies can be resolved (without resorting to assembly resolve event hacks).

This was particularly noticeable when I changed to an earlier version of the extension. There was a bindingRedirect in the devenv.exe.config, that was looking for an assembly that no longer existed. The extension failed to work completely.

image

There have also been reports of the GitHub icon missing from the Start Page. This used to happen in the past when the assembly containing the icon couldn't be resolved by its fully qualified name. This might happen if the devenv.exe.config hasn't been updated and the assembly version on disk doesn't match the assembly range in the bindingRedirect.

Here's an example of one of the GitHub extension's entries in devenv.exe.config.

<dependentAssembly>
    <assemblyIdentity name="GitHub.UI" publicKeyToken="bc1bd09f2901c82e" culture="neutral"/>
    <bindingRedirect oldVersion="0.0.0.0-2.3.2.33" newVersion="2.3.2.33"/>
    <codeBase version="2.3.2.33" href="C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\GitHub\GitHub\GitHub.UI.dll"/>
</dependentAssembly>

If this wan't updated and the version on disk changed to say, 2.3.3.44, Visual Studio wouldn't know where to find the GitHub.UI.dll assembly.

@tinaschrepfer @Michael-Eng,
Is this a known issue or a likely symptom of what has been reported in #1213?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0