8000 Only show sign in with browser for github.com · github/VisualStudio@e0dafc8 · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit e0dafc8

Browse files
jcansdalejcansdale
committed
Only show sign in with browser for github.com
1 parent a37ed48 commit e0dafc8

File tree

1 file changed

+28
-21
lines changed

1 file changed

+28
-21
lines changed

‎src/GitHub.VisualStudio.UI/Views/Dialog/LoginCredentialsView.xaml

Lines changed: 28 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -90,27 +90,34 @@
9090
PromptText="{x:Static ghfvs:Resources.UserNameOrEmailPromptText}"
9191
Margin="0,0,0,10" AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.DotcomUsernameEmailTextBox}" />
9292

93-
<ghfvs:SecurePasswordBox x:Name="dotComPassword" PromptText="{x:Static ghfvs:Resources.PasswordPrompt}" AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.DotcomPasswordTextBox}"/>
94-
95-
<Border Style="{StaticResource LoginButtonBorder}" Margin="0 16 0 0">
96-
<Button
97-
x:Name="dotComLogInButton"
98-
Content="{x:Static ghfvs:Resources.LoginLink}"
99-
IsDefault="True"
100-
Command=""
101-
AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.DotcomSignInButton}" />
102-
</Border>
103-
104-
<Grid Margin="0 8">
105-
<Grid.ColumnDefinitions>
106-
<ColumnDefinition Width="*"/>
107-
<ColumnDefinition Width="Auto"/>
108-
<ColumnDefinition Width="*"/>
109-
</Grid.ColumnDefinitions>
110-
<Rectangle Grid.Column="0" Fill="#FFDDDDDD" Height="1"/>
111-
<TextBlock Grid.Column="1" Margin="8,0,8,4">or</TextBlock>
112-
<Rectangle Grid.Column="2" Fill="#FFDDDDDD" Height="1"/>
113-
</Grid>
93+
<!--
94+
Signing with with username/password is going away, see:
95+
https://developer.github.com/changes/2020-02-14-deprecating-oauth-auth-endpoint/
96+
Setting Visibility="Collapsed"
97+
-->
98+
<StackPanel Name="dotComUsernamePasswordPanel" Visibility="Collapsed">
99+
<ghfvs:SecurePasswordBox x:Name="dotComPassword" PromptText="{x:Static ghfvs:Resources.PasswordPrompt}" AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.DotcomPasswordTextBox}"/>
100+
101+
<Border Style="{StaticResource LoginButtonBorder}" Margin="0 16 0 0">
102+
<Button
103+
x:Name="dotComLogInButton"
104+
Content="{x:Static ghfvs:Resources.LoginLink}"
105+
IsDefault="True"
106+
Command=""
107+
AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.DotcomSignInButton}" />
108+
</Border>
109+
110+
<Grid Margin="0 8">
111+
<Grid.ColumnDefinitions>
112+
<ColumnDefinition Width="*"/>
113+
<ColumnDefinition Width="Auto"/>
114+
<ColumnDefinition Width="*"/>
115+
</Grid.ColumnDefinitions>
116+
<Rectangle Grid.Column="0" Fill="#FFDDDDDD" Height="1"/>
117+
<TextBlock Grid.Column="1" Margin="8,0,8,4">or</TextBlock>
118+
<Rectangle Grid.Column="2" Fill="#FFDDDDDD" Height="1"/>
119+
</Grid>
120+
</StackPanel>
114121

115122
<StackPanel Orientation="Horizontal" HorizontalAlignment="Center">
116123
<ghfvs:GitHubActionLink x:Name="dotComSsaLogInButton" Content="{x:Static ghfvs:Resources.SignInWithYourBrowser}"/>

0 commit comments

Comments
 (0)
0