8000 Items in file-list/tree-view do not activate on mouse-down any more · Issue #12186 · gitextensions/gitextensions · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Items in file-list/tree-view do not activate on mouse-down any more #12186

Open
mdonatas opened this issue Feb 9, 2025 · 4 comments
Open

Items in file-list/tree-view do not activate on mouse-down any more #12186

mdonatas opened this issue Feb 9, 2025 · 4 comments
Labels
👓 status: needs review

Comments

@mdonatas
Copy link
Contributor
mdonatas commented Feb 9, 2025

Environment

  • GitExtensions version: master @ a9dfc19
  • .NET version: 8.0

Issue description

Until recently items in file list view would activate on mouse-down, not any more.

In this screenshot the first item is active while a mouse is pressed-down on to the third item.

  1. Partial selection of the third item is visible as its icon has selection background
  2. The item itself is not selected

Image

This gives an impression that something is broken, the the software is slow to react to user input.

Also the icon has different color background when selected than the row, this also looks like a visual bug. I hope this wasn't intended :)

Steps to reproduce

  • Select an item in the tree
  • Mouse-down on another item

Result: The item doesn't activate

Did this work in previous version of GitExtensions?

Yes, yes it did

Diagnostics

No response
@gerhardol
Copy link
Member

#12116 (comment)

@mstv
Copy link
Member
mstv commented Feb 9, 2025

Also the icon has different color background when selected than the row, this also looks like a visual bug.

The selection becomes active on mouse up. This is a pretty common behavior: folder tree in Explorer, quick view for folders and files in TotalCommander.
With #12150, the icon is not highlighted any longer - but it has other drawbacks.

@mdonatas
Copy link
Contributor Author

@mstv it's just that this is not how it used to be. Now it's "slow" to react compared to the list implementation.

Also, I've noticed that I very often click on the item while still moving a mouse slightly. This was absolutely not a problem previously but now it kinda attempts to drag it and doesn't activate it. So more than 50% of the time the click doesn't register while using GE in the same way as I've always used it :/

Tree functionality per-se is great but interacting with it is much clunkier with how it is now.

@mstv
Copy link
Member
mstv commented Feb 10, 2025

  1. Regarding mouse move / drag: A manipulation of _dragBoxFromMouseDown in FileStatusListView_MouseDown might help.

  2. Perhaps, one (you?) succeeds in moving the selection handling from MultiSelectTreeView.BeforeSelectHandler to OnMouseDown. Then there might even be no need for 1. tinkering DragSize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👓 status: needs review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdonatas @gerhardol @mstv
0