8000 [FrameworkBundle] Fixed validator factory definition when the Validat… · ghostika/symfony@a74b758 · GitHub
[go: up one dir, main page]
Skip to content

Commit a74b758

Browse files
webmozartwebmozart
committed
[FrameworkBundle] Fixed validator factory definition when the Validator API is "auto" for PHP < 5.3.9
1 parent 0801a3a commit a74b758

16 files changed

+222
-22
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,15 +457,30 @@ private function addValidationSection(ArrayNodeDefinition $rootNode)
457457
->booleanNode('strict_email')->defaultFalse()->end()
458458
->enumNode('api')
459459
->values(array('2.4', '2.5', '2.5-bc', 'auto'))
460-
->defaultValue('auto')
461460
->beforeNormalization()
461+
// XML/YAML parse as numbers, not as strings
462462
->ifTrue(function ($v) { return is_scalar($v); })
463463
->then(function ($v) { return (string) $v; })
464464
->end()
465465
->end()
466466
->end()
467467
->end()
468468
->end()
469+
->validate()
470+
->ifTrue(function ($v) { return !isset($v['validation']['api']) || 'auto' === $v['validation']['api']; })
471+
->then(function ($v) {
472+
// This condition is duplicated in ValidatorBuilder. This
473+
// duplication is necessary in order to know the desired
474+
// API version already during container configuration
475+
// (to adjust service classes etc.)
476+
// See https://github.com/symfony/symfony/issues/11580
477+
$v['validation']['api'] = version_compare(PHP_VERSION, '5.3.9', '<')
478+
? '2.4'
479+
: '2.5-bc';
480+
481+
return $v;
482+
})
483+
->end()
469484
;
470485
}
471486

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -714,21 +714,23 @@ private function registerValidationConfiguration(array $config, ContainerBuilder
714714
$validatorBuilder->addMethodCall('setMetadataCache', array(new Reference('validator.mapping.cache.'.$config['cache'])));
715715
}
716716

717-
if ('auto' !== $config['api']) {
718-
switch ($config['api']) {
719-
case '2.4':
720-
$api = Validation::API_VERSION_2_4;
721-
break;
722-
case '2.5':
723-
$api = Validation::API_VERSION_2_5;
724-
break;
725-
default:
726-
$api = Validation::API_VERSION_2_5_BC;
727-
break;
728-
}
729-
730-
$validatorBuilder->addMethodCall('setApiVersion', array($api));
731-
}
717+
switch ($config['api']) {
718+
case '2.4':
719+
$api = Validation::API_VERSION_2_4;
720+
break;
721+
case '2.5':
722+
$api = Validation::API_VERSION_2_5;
723+
break;
724+
default:
725+
$api = Validation::API_VERSION_2_5_BC;
726+
break;
727+
}
728+
729+
$validatorBuilder->addMethodCall('setApiVersion', array($api));
730+
731+
// You can use this parameter to check the API version in your own
732+
// bundle extension classes
733+
$container->setParameter('validator.api', $api);
732734
}
733735

734736
private function getValidatorXmlMappingFiles(ContainerBuilder $container)

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ protected static function getBundleDefaultConfig()
129129
'static_method' => array('loadValidatorMetadata'),
130130
'translation_domain' => 'validators',
131131
'strict_email' => false,
132-
'api' => 'auto',
132+
'api' => version_compare(PHP_VERSION, '5.3.9', '<') ? '2.4' : '2.5-bc',
133133
),
134134
'annotations' => array(
135135
'cache' => 'file',

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/validation_2_5_api.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<?php
2+
3+
$container->loadFromExtension('framework', array(
4+
'secret' => 's3cr3t',
5+
'validation' => array(
6+
'enabled' => true,
7+
'api' => '2.5',
8+
),
9+
));

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/validation_2_5_bc_api.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<?php
2+
3+
$container->loadFromExtension('framework', array(
4+
'secret' => 's3cr3t',
5+
'validation' => array(
6+
'enabled' => true,
7+
'api' => '2.5-bc',
8+
),
9+
));

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/validation_auto_api.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<?php
2+
3+
$container->loadFromExtension('framework', array(
4+
'secret' => 's3cr3t',
5+
'validation' => array(
6+
'enabled' => true,
7+
'api' => 'auto',
8+
),
9+
));

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/validation_implicit_api.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?php
2+
3+
$container->loadFromExtension('framework', array(
4+
'secret' => 's3cr3t',
5+
'validation' => array(
6+
'enabled' => true,
7+
),
8+
));

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/validation_2_5_api.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<?xml version="1.0" ?>
2+
3+
<container xmlns="http://symfony.com/schema/dic/services"
4+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xmlns:framework="http://symfony.com/schema/dic/symfony"
6+
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd
7+
http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd">
8+
9+
<framework:config secret="s3cr3t">
10+
<framework:validation enabled="true" api="2.5" />
11+
</framework:config>
12+
</container>

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/validation_2_5_bc_api.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<?xml version="1.0" ?>
2+
3+
<container xmlns="http://symfony.com/schema/dic/services"
4+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xmlns:framework="http://symfony.com/schema/dic/symfony"
6+
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd
7+
http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd">
8+
9+
<framework:config secret="s3cr3t">
10+
<framework:validation enabled="true" api="2.5-bc" />
11+
</framework:config>
12+
</container>

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/validation_auto_api.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<?xml version="1.0" ?>
2+
3+
<container xmlns="http://symfony.com/schema/dic/services"
4+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xmlns:framework="http://symfony.com/schema/dic/symfony"
6+
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd
7+
http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd">
8+
9+
<framework:config secret="s3cr3t">
10+
<framework:validation enabled="true" api="auto" />
11+
</framework:config>
12+
</container>

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/validation_implicit_api.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<?xml version="1.0" ?>
2+
3+
<container xmlns="http://symfony.com/schema/dic/services"
4+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xmlns:framework="http://symfony.com/schema/dic/symfony"
6+
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd
7+
http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd">
8+
9+
<framework:config secret="s3cr3t">
10+
<framework:validation enabled="true" />
11+
</framework:config>
12+
</container>

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/validation_2_5_api.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
framework:
2+
secret: s3cr3t
3+
validation:
4+
enabled: true
5+
api: 2.5

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/validation_2_5_bc_api.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
framework:
2+
secret: s3cr3t
3+
validation:
4+
enabled: true
5+
api: 2.5-bc

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/validation_auto_api.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+framework:
2+
secret: s3cr3t
3+
validation:
4+
enabled: true
5+
api: auto

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/validation_implicit_api.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
framework:
2+
secret: s3cr3t
3+
validation:
4+
enabled: true

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 86 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ public function testValidation()
265265

266266
$calls = $container->getDefinition('validator.builder')->getMethodCalls();
267267

268-
$this->assertCount(6, $calls);
268+
$this->assertCount(7, $calls);
269269
$this->assertSame('setConstraintValidatorFactory', $calls[0][0]);
270270
$this->assertEquals(array(new Reference('validator.validator_factory')), $calls[0][1]);
271271
$this->assertSame('setTranslator', $calls[1][0]);
@@ -278,6 +278,13 @@ public function testValidation()
278278
$this->assertSame(array('loadValidatorMetadata'), $calls[4][1]);
279279
$this->assertSame('setMetadataCache', $calls[5][0]);
280280
$this->assertEquals(array(new Reference('validator.mapping.cache.apc')), $calls[5][1]);
281+
$this->assertSame('setApiVersion', $calls[6][0]);
282+
283+
if (version_compare(PHP_VERSION, '5.3.9', '<')) {
284+
$this->assertEquals(array(Validation::API_VERSION_2_4), $calls[6][1]);
285+
} else {
286+
$this->assertEquals(array(Validation::API_VERSION_2_5_BC), $calls[6][1]);
287+
}
281288
}
282289

283290
public function testFullyConfiguredValidationService()
@@ -319,7 +326,7 @@ public function testValidationAnnotations()
319326

320327
$calls = $container->getDefinition('validator.builder')->getMethodCalls();
321328

322-
$this->assertCount(6, $calls);
329+
$this->assertCount(7, $calls);
323330
$this->assertSame('enableAnnotationMapping', $calls[4][0]);
324331
$this->assertEquals(array(new Reference('annotation_reader')), $calls[4][1]);
325332
$this->assertSame('addMethodMapping', $calls[5][0]);
@@ -337,7 +344,7 @@ public function testValidationPaths()
337344

338345
$calls = $container->getDefinition('validator.builder')->getMethodCalls();
339346

340-
$this->assertCount(7, $calls);
347+
$this->assertCount(8, $calls);
341348
$this->assertSame('addXmlMappings', $calls[3][0]);
342349
$this->assertSame('addYamlMappings', $calls[4][0]);
343350
$this->assertSame('enableAnnotationMapping', $calls[5][0]);
@@ -360,12 +367,12 @@ public function testValidationNoStaticMethod()
360367

361368
$calls = $container->getDefinition('validator.builder')->getMethodCalls();
362369

363-
$this->assertCount(4, $calls);
370+
$this->assertCount(5, $calls);
364371
$this->assertSame('addXmlMappings', $calls[3][0]);
365372
// no cache, no annotations, no static methods
366373
}
367374

368-
public function testValidationApiVersion()
375+
public function testValidation2Dot4Api()
369376
{
370377
$container = $this->createContainerFromFile('validation_2_4_api');
371378

@@ -380,6 +387,80 @@ public function testValidationApiVersion()
380387
// no cache, no annotations
381388
}
382389

390+
public function testValidation2Dot5Api()
391+
{
392+
$container = $this->createContainerFromFile('validation_2_5_api');
393+
394+
$calls = $container->getDefinition('validator.builder')->getMethodCalls();
395+
396+
$this->assertCount(6, $calls);
397+
$this->assertSame('addXmlMappings', $calls[3][0]);
398+
$this->assertSame('addMethodMapping', $calls[4][0]);
399+
$this->assertSame(array('loadValidatorMetadata'), $calls[4][1]);
400+
$this->assertSame('setApiVersion', $calls[5][0]);
401+
$this->assertSame(array(Validation::API_VERSION_2_5), $calls[5][1]);
402+
// no cache, no annotations
403+
}
404+
405+
public function testValidation2Dot5BcApi()
406+
{
407+
$container = $this->createContainerFromFile('validation_2_5_bc_api');
408+
409+
$calls = $container->getDefinition('validator.builder')->getMethodCalls();
410+
411+
$this->assertCount(6, $calls);
412+
$this->assertSame('addXmlMappings', $calls[3][0]);
413+
$this->assertSame('addMethodMapping', $calls[4][0]);
414+
$this->assertSame(array('loadValidatorMetadata'), $calls[4][1]);
415+
$this->assertSame('setApiVersion', $calls[5][0]);
416+
$this->assertSame(array(Validation::API_VERSION_2_5_BC), $calls[5][1]);
417+
// no cache, no annotations
418+
}
419+
420+
public function testValidationImplicitApi()
421+
{
422+
$container = $this->createContainerFromFile('validation_implicit_api');
423+
424+
$calls = $container->getDefinition('validator.builder')->getMethodCalls();
425+
426+
$this->assertCount(6, $calls);
427+
$this->assertSame('addXmlMappings', $calls[3][0]);
428+
$this->assertSame('addMethodMapping', $calls[4][0]);
429+
$this->assertSame(array('loadValidatorMetadata'), $calls[4][1]);
430+
$this->assertSame('setApiVersion', $calls[5][0]);
431+
// no cache, no annotations
432+
433+
if (version_compare(PHP_VERSION, '5.3.9', '<')) {
434+
$this->assertSame(array(Validation::API_VERSION_2_4), $calls[5][1]);
435+
} else {
436+
$this->assertSame(array(Validation::API_VERSION_2_5_BC), $calls[5][1]);
437+
}
438+
}
439+
440+
/**
441+
* This feature is equivalent to the implicit api, only that the "api"
442+
* key is explicitly set to "auto".
443+
*/
444+
public function testValidationAutoApi()
445+
{
446+
$container = $this->createContainerFromFile('validation_auto_api');
447+
448+
$calls = $container->getDefinition('validator.builder')->getMethodCalls();
449+
450+
$this->assertCount(6, $calls);
451+
$this->assertSame('addXmlMappings', $calls[3][0]);
452+
$this->assertSame('addMethodMapping', $calls[4][0]);
453+
$this->assertSame(array('loadValidatorMetadata'), $calls[4][1]);
454+
$this->assertSame('setApiVersion', $calls[5][0]);
455+
// no cache, no annotations
456+
457+
if (version_compare(PHP_VERSION, '5.3.9', '<')) {
458+
$this->assertSame(array(Validation::API_VERSION_2_4), $calls[5][1]);
459+
} else {
460+
$this->assertSame(array(Validation::API_VERSION_2_5_BC), $calls[5][1]);
461+
}
462+
}
463+
383464
public function testFormsCanBeEnabledWithoutCsrfProtection()
384465
{
385466
$container = $this->createContainerFromFile('form_no_csrf');

0 commit comments

Comments
 (0)
0