8000 gguf-py : correct charsmap parameter typing by CISC · Pull Request #13701 · ggml-org/llama.cpp · GitHub
[go: up one dir, main page]
Skip to content

gguf-py : correct charsmap parameter typing #13701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

gguf-py : correct charsmap parameter typing #13701

merged 1 commit into from
May 22, 2025

Conversation

CISC
Copy link
Collaborator
@CISC CISC commented May 22, 2025

Typing is incorrect, but was never noticed because pyright doesn't know the typing from sentencepiece.

@github-actions github-actions bot added the python python script changes label May 22, 2025
@CISC CISC requested a review from ngxson May 22, 2025 09:34
@ngxson ngxson requested a review from compilade May 22, 2025 09:38
@CISC
Copy link
Collaborator Author
CISC commented May 22, 2025

See https://github.com/ggml-org/llama.cpp/actions/runs/15183547024/job/42698535633?pr=13693

@ngxson ngxson merged commit 5be24af into master May 22, 2025
5 checks passed
@CISC CISC deleted the cisc/precompiled-charsmap-is-bytes branch May 22, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngxson ngxson ngxson approved these changes

@compilade compilade Awaiting requested review from compilade

Assignees
No one assigned
Labels
python python script changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CISC @ngxson
0