10000 Fixed the serialization of byte-string objects in Python 3 by xvillaneau · Pull Request #551 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Fixed the serialization of byte-string objects in Python 3 #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2019
Merged

Fixed the serialization of byte-string objects in Python 3 #551

merged 2 commits into from
Nov 11, 2019

Conversation

xvillaneau
Copy link
Contributor

Fixes #550

The serializer was returning lists of integers when attempting to serialize bytes. On top of that, the behavior of sentry_sdk.utils.safe_repr was decoding non-printable characters, and generally not behaving as expected.

Both issues were fixed for Python 3. safe_repr still has the bug in Python 2, but the solution for that will not be straightforward.

@untitaker untitaker merged commit 8cc48dc into getsentry:master Nov 11, 2019
@untitaker
Copy link
Member

Solid work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bytes Objects serialized as list of integers in Python 3
2 participants
@xvillaneau @untitaker
0