8000 Revert `traces_sample_rate` default change by antonpirker · Pull Request #4362 · getsentry/sentry-python · GitHub
[go: up one dir, main page]

Skip to content

Revert traces_sample_rate default change #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

antonpirker
Copy link
Member
@antonpirker antonpirker commented May 5, 2025

The default of traces_sample_rate should be None. This was a misunderstanding. With this default tracing without performance (twp) works, and this is the behavior that we like to have.

Original change is in this PR: #4335

See also this for better understanding: https://develop.sentry.dev/sdk/telemetry/traces/trace-propagation-cheat-sheet/

@antonpirker antonpirker marked this pull request as ready for review May 5, 2025 12:47
@antonpirker antonpirker requested a review from a team as a code owner May 5, 2025 12:47
@antonpirker antonpirker requested a review from sl0thentr0py May 5, 2025 12:47
Copy link
Member
@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonpirker can you link the PR that this PR is reverting for context?

A58B
@antonpirker
Copy link
Member Author

that's a duplicate of #4335

@antonpirker antonpirker closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0