8000 feat(tests): Add optional cutoff to toxgen by sentrivana · Pull Request #4243 · getsentry/sentry-python · GitHub
[go: up one dir, main page]

Skip to content

feat(tests): Add optional cutoff to toxgen #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Conversation

sentrivana
Copy link
Contributor
@sentrivana sentrivana commented Apr 4, 2025

This will be useful to identify old versions of packages when we're doing a deprecation round.

@sentrivana sentrivana requested a review from a team as a code owner April 4, 2025 11:17
@sentrivana sentrivana requested a review from antonpirker April 4, 2025 11:17
Copy link
codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (adcfa0f) to head (a91cbf5).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4243      +/-   ##
==========================================
- Coverage   79.54%   79.50%   -0.04%     
==========================================
  Files         142      142              
  Lines       15898    15898              
  Branches     2721     2721              
==========================================
- Hits        12646    12640       -6     
- Misses       2388     2391       +3     
- Partials      864      867       +3     

see 5 files with indirect coverage changes

Copy link
Member
@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sentrivana sentrivana merged commit 7cb0451 into master Apr 9, 2025
138 checks passed
@sentrivana sentrivana deleted the ivana/even-more-toxgen branch April 9, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0