8000 fix xfails · getsentry/sentry-python@f98614d · GitHub
[go: up one dir, main page]
Skip to content

Commit f98614d

Browse files
sentrivanasentrivana
committed
fix xfails
1 parent be95b97 commit f98614d

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

‎tests/new_scopes_compat/test_new_scopes_compat.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"""
1414

1515

16-
@pytest.mark.xfail("will be removed in 3.0")
16+
@pytest.mark.xfail(reason="will be removed in 3.0")
1717
def test_configure_scope_sdk1(sentry_init, capture_events):
1818
"""
1919
Mutate data in a `with configure_scope` block.
@@ -43,7 +43,7 @@ def test_configure_scope_sdk1(sentry_init, capture_events):
4343
assert event_z["tags"] == {"A": 1, "B1": 1, "B2": 1, "Z": 1}
4444

4545

46-
@pytest.mark.xfail("will be removed in 3.0")
46+
@pytest.mark.xfail(reason="will be removed in 3.0")
4747
def test_push_scope_sdk1(sentry_init, capture_events):
4848
"""
4949
Mutate data in a `with push_scope` block
@@ -73,7 +73,7 @@ def test_push_scope_sdk1(sentry_init, capture_events):
7373
assert event_z["tags"] == {"A": 1, "Z": 1}
7474

7575

76-
@pytest.mark.xfail("will be removed in 3.0")
76+
@pytest.mark.xfail(reason="will be removed in 3.0")
7777
def test_with_hub_sdk1(sentry_init, capture_events):
7878
"""
7979
Mutate data in a `with Hub:` block
@@ -103,7 +103,7 @@ def test_with_hub_sdk1(sentry_init, capture_events):
103103
assert event_z["tags"] == {"A": 1, "B1": 1, "B2": 1, "Z": 1}
104104

105105

106-
@pytest.mark.xfail("will be removed in 3.0")
106+
@pytest.mark.xfail(reason="will be removed in 3.0")
107107
def test_with_hub_configure_scope_sdk1(sentry_init, capture_events):
108108
"""
109109
Mutate data in a `with Hub:` containing a `with configure_scope` block
@@ -147,7 +147,7 @@ def test_with_hub_configure_scope_sdk1(sentry_init, capture_events):
147147
}
148148

149149

150-
@pytest.mark.xfail("will be removed in 3.0")
150+
@pytest.mark.xfail(reason="will be removed in 3.0")
151151
def test_with_hub_push_scope_sdk1(sentry_init, capture_events):
152152
"""
153153
Mutate data in a `with Hub:` containing a `with push_scope` block
@@ -183,7 +183,7 @@ def test_with_hub_push_scope_sdk1(sentry_init, capture_events):
183183
assert event_z["tags"] == {"A": 1, "B1": 1, "B5": 1, "Z": 1}
184184

185185

186-
@pytest.mark.xfail("will be removed in 3.0")
186+
@pytest.mark.xfail(reason="will be removed in 3.0")
187187
def test_with_cloned_hub_sdk1(sentry_init, capture_events):
188188
"""
189189
Mutate data in a `with cloned Hub:` block
@@ -213,7 +213,7 @@ def test_with_cloned_hub_sdk1(sentry_init, capture_events):
213213
assert event_z["tags"] == {"A": 1, "Z": 1}
214214

215215

216-
@pytest.mark.xfail("will be removed in 3.0")
216+
@pytest.mark.xfail(reason="will be removed in 3.0")
217217
def test_with_cloned_hub_configure_scope_sdk1(sentry_init, capture_events):
218218
"""
219219
Mutate data in a `with cloned Hub:` containing a `with configure_scope` block
@@ -249,7 +249,7 @@ def test_with_cloned_hub_configure_scope_sdk1(sentry_init, capture_events):
249249
assert event_z["tags"] == {"A": 1, "Z": 1}
250250

251251

252-
@pytest.mark.xfail("will be removed in 3.0")
252+
@pytest.mark.xfail(reason="will be removed in 3.0")
253253
def test_with_cloned_hub_push_scope_sdk1(sentry_init, capture_events):
254254
"""
255255
Mutate data in a `with cloned Hub:` containing a `with push_scope` block

‎tests/new_scopes_compat/test_new_scopes_compat_event.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ def _init_sentry_sdk(sentry_init):
330330
#
331331

332332

333-
@pytest.mark.xfail("will be removed in 3.0")
333+
@pytest.mark.xfail(reason="will be removed in 3.0")
334334
def test_event(sentry_init, capture_envelopes, expected_error, expected_transaction):
335335
_init_sentry_sdk(sentry_init)
336336

@@ -360,7 +360,7 @@ def test_event(sentry_init, capture_envelopes, expected_error, expected_transact
360360
assert attachment.payload.bytes == b"Hello World"
361361

362362

363-
@pytest.mark.xfail("will be removed in 3.0")
363+
@pytest.mark.xfail(reason="will be removed in 3.0")
364364
def test_event2(sentry_init, capture_envelopes, expected_error, expected_transaction):
365365
_init_sentry_sdk(sentry_init)
366366

@@ -397,7 +397,7 @@ def test_event2(sentry_init, capture_envelopes, expected_error, expected_transac
397397
assert attachment.payload.bytes == b"Hello World"
398398

399399

400-
@pytest.mark.xfail("will be removed in 3.0")
400+
@pytest.mark.xfail(reason="will be removed in 3.0")
401401
def test_event3(sentry_init, capture_envelopes, expected_error, expected_transaction):
402402
_init_sentry_sdk(sentry_init)
403403

@@ -434,7 +434,7 @@ def test_event3(sentry_init, capture_envelopes, expected_error, expected_transac
434434
assert attachment.payload.bytes == b"Hello World"
435435

436436

437-
@pytest.mark.xfail("will be removed in 3.0")
437+
@pytest.mark.xfail(reason="will be removed in 3.0")
438438
def test_event4(sentry_init, capture_envelopes, expected_error, expected_transaction):
439439
_init_sentry_sdk(sentry_init)
440440

@@ -471,7 +471,7 @@ def test_event4(sentry_init, capture_envelopes, expected_error, expected_transac
471471
assert attachment.payload.bytes == b"Hello World"
472472

473473

474-
@pytest.mark.xfail("will be removed in 3.0")
474+
@pytest.mark.xfail(reason="will be removed in 3.0")
475475
def test_event5(sentry_init, capture_envelopes, expected_error, expected_transaction):
476476
_init_sentry_sdk(sentry_init)
477477

‎tests/test_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,14 +185,14 @@ def test_set_tags(sentry_init, capture_events):
185185
}, "Updating tags with empty dict changed tags"
186186

187187

188-
@pytest.mark.xfail("configure_scope will be removed in 3.0")
188+
@pytest.mark.xfail(reason="configure_scope will be removed in 3.0")
189189
def test_configure_scope_deprecation():
190190
with pytest.warns(DeprecationWarning):
191191
with configure_scope():
192192
...
193193

194194

195-
@pytest.mark.xfail("push_scope will be removed in 3.0")
195+
@pytest.mark.xfail(reason="push_scope will be removed in 3.0")
196196
def test_push_scope_deprecation():
197197
with pytest.warns(DeprecationWarning):
198198
with push_scope():

‎tests/test_transport.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,7 @@ def test_metric_bucket_limits_with_all_namespaces(
649649
]
650650

651651

652-
@pytest.mark.xfail("hub will be removed in 3.0")
652+
@pytest.mark.xfail(reason="hub will be removed in 3.0")
653653
def test_hub_cls_backwards_compat():
654654
class TestCustomHubClass(Hub):
655655
pass

0 commit comments

Comments
 (0)
0