fix more tests

colin-sentry · colin-sentry · commit cd5ddd5c337a · 2025-04-02T08:42:28.000-04:00
diff --git a/sentry_sdk/logger.py b/sentry_sdk/logger.py
@@ -19,7 +19,12 @@ def _capture_log(severity_text, severity_number, template, **kwargs):
     for k, v in kwargs.items():
         attrs[f"sentry.message.parameters.{k}"] = (
             v
-            if (isinstance(v, str) or isinstance(v, int) or isinstance(v, bool))
+            if (
+                isinstance(v, str)
+                or isinstance(v, int)
+                or isinstance(v, bool)
+                or isinstance(v, float)
+            )
             else repr(v)
         )
 
diff --git a/tests/test_logs.py b/tests/test_logs.py
@@ -254,7 +254,7 @@ def test_logs_tied_to_spans(sentry_init, capture_envelopes):
     envelopes = capture_envelopes()
 
     with sentry_sdk.start_transaction(name="test-transaction"):
-        with sentry_sdk.start_span(description="test-span") as span:
+        with sentry_sdk.start_span(name="test-span") as span:
             sentry_sdk.logger.warning("This is a log tied to a span")
 
     get_client().flush()

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,12 @@ def _capture_log(severity_text, severity_number, template, **kwargs):`
`19`	`19`	`for k, v in kwargs.items():`
`20`	`20`	`attrs[f"sentry.message.parameters.{k}"] = (`
`21`	`21`	`v`
`22`		`- if (isinstance(v, str) or isinstance(v, int) or isinstance(v, bool))`
	`22`	`+ if (`
	`23`	`+ isinstance(v, str)`
	`24`	`+ or isinstance(v, int)`
	`25`	`+ or isinstance(v, bool)`
	`26`	`+ or isinstance(v, float)`
	`27`	`+ )`
`23`	`28`	`else repr(v)`
`24`	`29`	`)`
`25`	`30`