Fix socket (#3819)

sl0thentr0py · web-flow · commit 10bc3fa93687 · 2024-11-22T15:32:51.000+01:00
diff --git a/sentry_sdk/integrations/socket.py b/sentry_sdk/integrations/socket.py
@@ -59,7 +59,9 @@ def create_connection(
             origin=SocketIntegration.origin,
             only_if_parent=True,
         ) as span:
-            span.set_data("address", address)
+            host, port = address
+            span.set_data("address.host", host)
+            span.set_data("address.port", port)
             span.set_data("timeout", timeout)
             span.set_data("source_address", source_address)
 
diff --git a/tests/integrations/socket/test_socket.py b/tests/integrations/socket/test_socket.py
@@ -42,9 +42,9 @@ def test_create_connection_trace(sentry_init, capture_events):
     assert connect_span["description"] == "example.com:443"
     assert connect_span["data"] == ApproxDict(
         {
-            "address": ["example.com", 443],
+            "address.host": "example.com",
+            "address.port": 443,
             "timeout": timeout,
-            "source_address": None,
         }
     )
 

Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,9 @@ def test_create_connection_trace(sentry_init, capture_events):`
`42`	`42`	`assert connect_span["description"] == "example.com:443"`
`43`	`43`	`assert connect_span["data"] == ApproxDict(`
`44`	`44`	`{`
`45`		`- "address": ["example.com", 443],`
	`45`	`+ "address.host": "example.com",`
	`46`	`+ "address.port": 443,`
`46`	`47`	`"timeout": timeout,`
`47`		`- "source_address": None,`
`48`	`48`	`}`
`49`	`49`	`)`
`50`	`50`