8000 Unify console instrumentation · Issue #4532 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

Unify console instrumentation #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AbhiPrasad opened this issue Feb 9, 2022 · 1 comment · Fixed by #16024
Closed

Unify console instrumentation #4532

AbhiPrasad opened this issue Feb 9, 2022 · 1 comment · Fixed by #16024
Assignees
@AbhiPrasad
Labels
hacktoberfest Meta: Help Wanted Package: core Issues related to the Sentry Core SDK

Comments

@AbhiPrasad
Copy link
Member

The console instrumentation in the SDK seem to duplicate code. Maybe we can find a way to unify them? We can also improve testing this way, and it may help save bundle size.

the instrumentConsole utility:

sentry-javascript/packages/utils/src/instrument.ts

Line 109 in 5df78df

function instrumentConsole(): void {

the node Console integration: https://github.com/getsentry/sentry-javascript/blob/master/packages/node/src/integrations/console.ts

the CaptureConsole integration: https://github.com/getsentry/sentry-javascript/blob/master/packages/integrations/src/captureconsole.ts
@AbhiPrasad AbhiPrasad added Meta: Help Wanted Package: core Issues related to the Sentry Core SDK Status: Backlog labels Feb 9, 2022
@AbhiPrasad AbhiPrasad mentioned this issue Feb 9, 2022
Merged
@AbhiPrasad AbhiPrasad mentioned this issue Mar 18, 2022
Merged
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #16024, which was included in the 9.13.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbhiPrasad AbhiPrasad

Labels
hacktoberfest Meta: Help Wanted Package: core Issues related to the Sentry Core SDK
Projects
None yet
Milestone
No milestone
2 participants
@HazAT @AbhiPrasad
0