10000 Allow browser SDKs to use `skipOpenTelemetrySetup` · Issue #16289 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

Allow browser SDKs to use skipOpenTelemetrySetup #16289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Stanzilla opened this issue May 14, 2025 · 3 comments
Closed

Allow browser SDKs to use skipOpenTelemetrySetup #16289

Stanzilla opened this issue May 14, 2025 · 3 comments
Labels
Feature

Comments

@Stanzilla
Copy link

Problem Statement

Currently it is not possible to use skipOpenTelemetrySetup: true when using the browser or nextjs SDK, which is a bit problematic since we are running into a duplicate events issue like #15830 here.

Solution Brainstorm

Allow skipOpenTelemetrySetup in the browser/framework SDKs to be passed through to @sentry/node
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 May 14, 2025
@mydea
Copy link
Member
mydea commented May 14, 2025

The browser does not have open telemetry, so this setting makes no sense there. Can you not configure this setting on the server side of your next SDK?

< 8000 div class="TimelineItem js-targetable-element" data-team-hovercards-enabled id="event-17652522434">
@getsantry getsantry bot removed the Waiting for: Product Owner label May 14, 2025
@Stanzilla
Copy link
Author

True, I think I got confused because our server implementation also uses @sentry/nextjs instead of node and I got a type error when trying to add the setting. I no longer get the type warning right now though and it looks like the @sentry/nextjs DOES support it, judging by the types https://github.com/getsentry/sentry-javascript/blob/develop/packages/nextjs/src/server/index.ts#L95

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 May 14, 2025
@andreiborza
Copy link
Member

Closing this, as Francesco said, browser sdks don't use OpenTelemetry and node based SDKs have this setting exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Stanzilla @mydea @andreiborza
0