fix(react): From location can be undefined in Tanstack Router Instrumentation (#15235)

tannerlinsley · Lms24 · commit 0a9c4d0be633 · 2025-01-30T17:52:25.000+01:00
fixes #15234 Due to a big bug in TanStack Router getting fixed, this needs an optional chain to not die.
diff --git a/packages/react/src/tanstackrouter.ts b/packages/react/src/tanstackrouter.ts
@@ -65,7 +65,7 @@ export function tanstackRouterBrowserTracingIntegration(
         // The onBeforeNavigate hook is called at the very beginning of a navigation and is only called once per navigation, even when the user is redirected
         castRouterInstance.subscribe('onBeforeNavigate', onBeforeNavigateArgs => {
           // onBeforeNavigate is called during pageloads. We can avoid creating navigation spans by comparing the states of the to and from arguments.
-          if (onBeforeNavigateArgs.toLocation.state === onBeforeNavigateArgs.fromLocation.state) {
+          if (onBeforeNavigateArgs.toLocation.state === onBeforeNavigateArgs.fromLocation?.state) {
             return;
           }
 

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ export function tanstackRouterBrowserTracingIntegration(`
`65`	`65`	`// The onBeforeNavigate hook is called at the very beginning of a navigation and is only called once per navigation, even when the user is redirected`
`66`	`66`	`castRouterInstance.subscribe('onBeforeNavigate', onBeforeNavigateArgs => {`
`67`	`67`	`// onBeforeNavigate is called during pageloads. We can avoid creating navigation spans by comparing the states of the to and from arguments.`
`68`		`- if (onBeforeNavigateArgs.toLocation.state === onBeforeNavigateArgs.fromLocation.state) {`
	`68`	`+ if (onBeforeNavigateArgs.toLocation.state === onBeforeNavigateArgs.fromLocation?.state) {`
`69`	`69`	`return;`
`70`	`70`	`}`
`71`	`71`