Description
github upload-artifact v3 is deprecated and v4 currently doesn't allow uploading different filepaths to the same artifact name
upstream issue: actions/upload-artifact#478
currently craft expects the artifact name to be github.sha
this blocks:
- build(ci): Update actions/upload-artifact to v4 relay#3876
- all-repos: update actions/upload-artifact to v4 symbolicator#1503
- all-repos: update actions/upload-artifact to v4 sentry-python#3381
- meta: Revert upload-artifact bump (#2110) sentry-cli#2119
- and probably a few others
i propose a quick fix to check for this as a prefix if {sha} isn't found (so that we don't break things): craft-{sha}-
also, this is annoying but there are going to be multiple artifact ziparchives now with craft-{sha}- for example symbolicator will need the following, and current code assumes just one artifact per revision
- /^symbolicator-Darwin-universal$/
- /^symbolicator-Linux-x86_64$/
- /^symbolicator-Linux-x86_64-debug.zip$/
- /^symbolicator-aarch64-apple-darwin-debug.zip$/
- /^symbolicator-x86_64-apple-darwin-debug.zip$/
- /^symbolicli-Darwin-universal$/
- /^symbolicli-Linux-x86_64$/
- /^symbolicli-Windows-x86_64\.exe$/
- /^symsorter-Darwin-universal$/
- /^symsorter-Linux-x86_64$/
- /^symsorter-Windows-x86_64\.exe$/
- /^wasm-split-Darwin-universal$/
- /^wasm-split-Linux-x86_64$/
- /^wasm-split-Windows-x86_64\.exe$/
Metadata
Metadata
Assignees
Labels
No labels