8000 docs: update tests that are failing or not cleaning up resources · georg78sf/java-docs-samples@e308272 · GitHub
[go: up one dir, main page]

Skip to content

Commit e308272

Browse files
nnegreylesv
authored andcommitted
docs: update tests that are failing or not cleaning up resources
1 parent 05551c4 commit e308272

File tree

6 files changed

+36
-9
lines changed

6 files changed

+36
-9
lines changed

translate/cloud-client/src/main/java/com/example/translate/BatchTranslateText.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public static void batchTranslateText(
8686
client.batchTranslateTextAsync(request);
8787

8888
System.out.println("Waiting for operation to complete...");
89-
BatchTranslateResponse response = future.get(120, TimeUnit.SECONDS);
89+
BatchTranslateResponse response = future.get(180, TimeUnit.SECONDS);
9090
System.out.printf("Total Characters: %s\n", response.getTotalCharacters());
9191
System.out.printf("Translated Characters: %s\n", response.getTranslatedCharacters());
9292
}

translate/cloud-client/src/main/java/com/example/translate/BatchTranslateTextWithGlossary.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public static void batchTranslateTextWithGlossary(
104104
client.batchTranslateTextAsync(request);
105105

106106
System.out.println("Waiting for operation to complete...");
107-
BatchTranslateResponse response = future.get(120, TimeUnit.SECONDS);
107+
BatchTranslateResponse response = future.get(180, TimeUnit.SECONDS);
108108
// Display the translation for each input text provided
109109
System.out.printf("Total Characters: %s\n", response.getTotalCharacters());
110110
System.out.printf("Translated Characters: %s\n", response.getTranslatedCharacters());

translate/cloud-client/src/main/java/com/example/translate/BatchTranslateTextWithGlossaryAndModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public static void batchTranslateTextWithGlossaryAndModel(
111111
client.batchTranslateTextAsync(request);
112112

113113
System.out.println("Waiting for operation to complete...");
114-
BatchTranslateResponse response = future.get(120, TimeUnit.SECONDS);
114+
BatchTranslateResponse response = future.get(180, TimeUnit.SECONDS);
115115
// Display the translation for each input text provided
116116
System.out.printf("Total Characters: %s\n", response.getTotalCharacters());
117117
System.out.printf("Translated Characters: %s\n", response.getTranslatedCharacters());

translate/cloud-client/src/main/java/com/example/translate/BatchTranslateTextWithModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public static void batchTranslateTextWithModel(
101101
client.batchTranslateTextAsync(request);
102102

103103
System.out.println("Waiting for operation to complete...");
104-
BatchTranslateResponse response = future.get(120, TimeUnit.SECONDS);
104+
BatchTranslateResponse response = future.get(180, TimeUnit.SECONDS);
105105
// Display the translation for each input text provided
106106
System.out.printf("Total Characters: %s\n", response.getTotalCharacters());
107107
System.out.printf("Translated Characters: %s\n", response.getTranslatedCharacters());

vision/automl/src/test/java/com/google/cloud/vision/samples/automl/PredictionApiIT.java

Lines changed: 19 additions & 5 deletions

Original file line numberDiff line numberDiff line change
@@ -18,9 +18,14 @@
1818

1919
import static com.google.common.truth.Truth.assertThat;
2020

21+
import com.google.cloud.automl.v1beta1.AutoMlClient;
22+
import com.google.cloud.automl.v1beta1.DeployModelRequest;
23+
import com.google.cloud.automl.v1beta1.Model;
24+
import com.google.cloud.automl.v1beta1.ModelName;
2125
import java.io.ByteArrayOutputStream;
26+
import java.io.IOException;
2227
import java.io.PrintStream;
23-
28+
import java.util.concurrent.ExecutionException;
2429
import org.junit.After;
2530
import org.junit.Before;
2631
import org.junit.Test;
@@ -40,7 +45,19 @@ public class PredictionApiIT {
4045
private PrintStream out;
4146
4247
@Before
43-
public void setUp() {
48+
public void setUp() throws IOException, ExecutionException, InterruptedException {
49+
// Verify that the model is deployed for prediction
50+
try (AutoMlClient client = AutoMlClient.create()) {
51+
ModelName modelFullId = ModelName.of(PROJECT_ID, "us-central1", modelId);
52+
Model model = client.getModel(modelFullId);
53+
if (model.getDeploymentState() == Model.DeploymentState.UNDEPLOYED) {
54+
// Deploy the model if not deployed
55+
DeployModelRequest request =
56+
DeployModelRequest.newBuilder().setName(modelFullId.toString()).build();
57+
client.deployModelAsync(request).get();
58+
}
59+
}
60+
4461
bout = new ByteArrayOutputStream();
4562
out = new PrintStream(bout);
4663
System.setOut(out);
@@ -53,10 +70,7 @@ public void tearDown() {
5370

5471
@Test
5572
public void testPredict() {
56-
// Act
5773
PredictionApi.predict(PROJECT_ID, COMPUTE_REGION, modelId, filePath, scoreThreshold);
58-
59-
// Assert
6074
String got = bout.toString();
6175
assertThat(got).contains("dandelion");
6276
}

vision/beta/cloud-client/src/test/java/com/example/vision/DetectIT.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@
1818

1919
import static com.google.common.truth.Truth.assertThat;
2020

21+
import com.google.api.gax.paging.Page;
22+
import com.google.cloud.storage.Blob;
23+
import com.google.cloud.storage.Storage;
24+
import com.google.cloud.storage.Storage.BlobListOption;
25+
import com.google.cloud.storage.StorageOptions;
2126
import java.io.ByteArrayOutputStream;
2227
import java.io.IOException;
2328
import java.io.PrintStream;
@@ -135,5 +140,13 @@ public void testAsyncBatchAnnotateImagesGcs() throws Exception {
135140
// Assert
136141
String got = bout.toString();
137142
assertThat(got).contains("red:");
143+
144+
Storage storage = StorageOptions.getDefaultInstance().getService();
145+
146+
Page<Blob> blobs = storage.list(OUTPUT_BUCKET, BlobListOption.currentDirectory(),
147+
BlobListOption.prefix(OUTPUT_PREFIX + "/"));
148+
for (Blob blob : blobs.iterateAll()) {
149+
blob.delete();
150+
}
138151
}
139152
}

0 commit comments

Comments
 (0)
0