8000 Fix building ProviderNotRegistered exception message (#1020) · geocoder-php/php-common@7d40683 · GitHub
[go: up one dir, main page]

Skip to content

Commit 7d40683

Browse files
norkunasatymic
authored andcommitted
Fix building ProviderNotRegistered exception message (#1020)
1 parent eb49ea6 commit 7d40683

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

ProviderAggregator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public function registerProviders(array $providers = []): self
145145
public function using(string $name): self
146146
{
147147
if (!isset($this->providers[$name])) {
148-
throw ProviderNotRegistered::create($name ?? '', $this->providers);
148+
throw ProviderNotRegistered::create($name, array_keys($this->providers));
149149
}
150150

151151
$this->provider = $this->providers[$name];

Tests/ProviderAggregatorTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,12 @@ public function testRegisterProviders()
8585

8686
/**
8787
* @expectedException \Geocoder\Exception\ProviderNotRegistered
88+
* @expectedExceptionMessage Provider "non_existant" is not registered, so you cannot use it. Did you forget to register it or made a typo? Registered providers are: test1.
8889
*/
8990
public function testUsingNonExistantProviderShouldThrowAnException()
9091
{
92+
$this->geocoder->registerProvider(new MockProvider('test1'));
93+
9194
$this->geocoder->using('non_existant');
9295
}
9396

0 commit comments

Comments
 (0)
0