Prevent GeocoderService from instantiating providers on boot

Korri · Korri · commit 6637132a11e8 · 2018-06-22T14:02:29.000-04:00
This could cause performance issues as is instantiates the each provider that was setup in the configuration as the time of boot, event if they don't get use.
diff --git a/src/Providers/GeocoderService.php b/src/Providers/GeocoderService.php
@@ -25,19 +25,16 @@ public function boot()
             "config"
         );
         $this->mergeConfigFrom($configPath, "geocoder");
-        $geocoder = (new ProviderAndDumperAggregator)
-            ->registerProvidersFromConfig(collect(config("geocoder.providers")));
-        $this->app
-            ->singleton("geocoder", function () use ($geocoder) {
-                return $geocoder;
-            });
-        $this->app
-            ->instance(ProviderAndDumperAggregator::class, $geocoder);
     }
 
     public function register()
     {
         $this->app->alias("Geocoder", Geocoder::class);
+        $this->app->singleton(ProviderAndDumperAggregator::class, function () {
+            return (new ProviderAndDumperAggregator)
+                ->registerProvidersFromConfig(collect(config("geocoder.providers")));
+        });
+        $this->app->bind('geocoder', ProviderAndDumperAggregator::class);
     }
 
     public function provides() : array
