Don't pass null to adapter

canvural · web-flow · commit 65a9373d4e6a · 2019-05-23T14:04:16.000+02:00
Hello,

I had this issue with Guzzle.

Guzzle expects an array to its constructor, but here we were passing null.

This PR fixes that issue.
diff --git a/src/ProviderAndDumperAggregator.php b/src/ProviderAndDumperAggregator.php
@@ -219,14 +219,13 @@ protected function getArguments(array $arguments, string $provider) : array
         }
 
         $adapter = $this->getAdapterClass($provider);
-        $reader = null;
 
         if ($adapter) {
             if ($this->requiresReader($provider)) {
-                $reader = config('geocoder.reader');
+                array_unshift($arguments, new $adapter(config('geocoder.reader')));
+            } else {
+                array_unshift($arguments, new $adapter());
             }
-
-            array_unshift($arguments, new $adapter($reader));
         }
 
         return $arguments;

Original file line number	Diff line number	Diff line change
`@@ -219,14 +219,13 @@ protected function getArguments(array $arguments, string $provider) : array`
`219`	`219`	`}`
`220`	`220`
`221`	`221`	`$adapter = $this->getAdapterClass($provider);`
`222`		`- $reader = null;`
`223`	`222`
`224`	`223`	`if ($adapter) {`
`225`	`224`	`if ($this->requiresReader($provider)) {`
`226`		`- $reader = config('geocoder.reader');`
	`225`	`+ array_unshift($arguments, new $adapter(config('geocoder.reader')));`
	`226`	`+ } else {`
	`227`	`+ array_unshift($arguments, new $adapter());`
`227`	`228`	`}`
`228`		`-`
`229`		`- array_unshift($arguments, new $adapter($reader));`
`230`	`229`	`}`
`231`	`230`
`232`	`231`	`return $arguments;`