Add return types to Promises (#1151)

franmomu · web-flow · commit e87c4b49e175 · 2022-07-30T11:23:24.000+02:00
Add return types
diff --git a/src/Plugin/Promise/GeocoderFulfilledPromise.php b/src/Plugin/Promise/GeocoderFulfilledPromise.php
@@ -36,7 +36,7 @@ public function __construct(Collection $collection)
     /**
      * {@inheritdoc}
      */
-    public function then(callable $onFulfilled = null, callable $onRejected = null)
+    public function then(callable $onFulfilled = null, callable $onRejected = null): Promise
     {
         if (null === $onFulfilled) {
             return $this;
@@ -52,13 +52,15 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)
     /**
      * {@inheritdoc}
      */
-    public function getState()
+    public function getState(): string
     {
         return Promise::FULFILLED;
     }
 
     /**
      * {@inheritdoc}
+     *
+     * @return mixed
      */
     public function wait($unwrap = true)
     {
diff --git a/src/Plugin/Promise/GeocoderRejectedPromise.php b/src/Plugin/Promise/GeocoderRejectedPromise.php
@@ -35,7 +35,7 @@ public function __construct(Exception $exception)
     /**
      * {@inheritdoc}
      */
-    public function then(callable $onFulfilled = null, callable $onRejected = null)
+    public function then(callable $onFulfilled = null, callable $onRejected = null): Promise
     {
         if (null === $onRejected) {
             return $this;
@@ -51,13 +51,15 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)
     /**
      * {@inheritdoc}
      */
-    public function getState()
+    public function getState(): string
     {
         return Promise::REJECTED;
     }
 
     /**
      * {@inheritdoc}
+     *
+     * @return mixed
      */
     public function wait($unwrap = true)
     {

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function __construct(Collection $collection)`
`36`	`36`	`/**`
`37`	`37`	`* {@inheritdoc}`
`38`	`38`	`*/`
`39`		`- public function then(callable $onFulfilled = null, callable $onRejected = null)`
	`39`	`+ public function then(callable $onFulfilled = null, callable $onRejected = null): Promise`
`40`	`40`	`{`
`41`	`41`	`if (null === $onFulfilled) {`
`42`	`42`	`return $this;`
`@@ -52,13 +52,15 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)`
`52`	`52`	`/**`
`53`	`53`	`* {@inheritdoc}`
`54`	`54`	`*/`
`55`		`- public function getState()`
	`55`	`+ public function getState(): string`
`56`	`56`	`{`
`57`	`57`	`return Promise::FULFILLED;`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`/**`
`61`	`61`	`* {@inheritdoc}`
	`62`	`+ *`
	`63`	`+ * @return mixed`
`62`	`64`	`*/`
`63`	`65`	`public function wait($unwrap = true)`
`64`	`66`	`{`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function __construct(Exception $exception)`
`35`	`35`	`/**`
`36`	`36`	`* {@inheritdoc}`
`37`	`37`	`*/`
`38`		`- public function then(callable $onFulfilled = null, callable $onRejected = null)`
	`38`	`+ public function then(callable $onFulfilled = null, callable $onRejected = null): Promise`
`39`	`39`	`{`
`40`	`40`	`if (null === $onRejected) {`
`41`	`41`	`return $this;`
`@@ -51,13 +51,15 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)`
`51`	`51`	`/**`
`52`	`52`	`* {@inheritdoc}`
`53`	`53`	`*/`
`54`		`- public function getState()`
	`54`	`+ public function getState(): string`
`55`	`55`	`{`
`56`	`56`	`return Promise::REJECTED;`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`/**`
`60`	`60`	`* {@inheritdoc}`
	`61`	`+ *`
	`62`	`+ * @return mixed`
`61`	`63`	`*/`
`62`	`64`	`public function wait($unwrap = true)`
`63`	`65`	`{`