Fix too many trailing commas

R167 · R167 · commit 1189574f9b2f · 2021-02-16T15:37:46.000-08:00
diff --git a/src/python.grammar b/src/python.grammar
@@ -65,7 +65,7 @@ ImportStatement {
 }
 importedNames { commaSep<VariableName | VariableName kw<"as"> VariableName> }
 
-commaSep<expr> { expr ("," expr?)* }
+commaSep<expr> { expr ("," expr)* ","? }
 
 compoundStatement[@export] {
   IfStatement |
diff --git a/test/expression.txt b/test/expression.txt
@@ -163,13 +163,23 @@ Script(ExpressionStatement(AwaitExpression(await, CallExpression(VariableName, A
 x = [
   1, 2,
   # And
-  3, 4
+  3, 4,
 ]
 
 ==>
 
 Script(AssignStatement(VariableName, AssignOp, ArrayExpression(Number, Number, Comment, Number, Number)))
 
+# Too many commas in brackets
+
+x = [
+  1, 2,,
+]
+
+==>
+
+Script(AssignStatement(VariableName, AssignOp, ArrayExpression(Number, Number, ⚠)))
+
 # Conditional expression
 
 x = 5 if True else 1 if False else 0

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ ImportStatement {`
`65`	`65`	`}`
`66`	`66`	`importedNames { commaSep<VariableName \| VariableName kw<"as"> VariableName> }`
`67`	`67`
`68`		`-commaSep<expr> { expr ("," expr?)* }`
	`68`	`+commaSep<expr> { expr ("," expr)* ","? }`
`69`	`69`
`70`	`70`	`compoundStatement[@export] {`
`71`	`71`	`IfStatement \|`