feature symfony#9186 [Console] Throw an exception if the command does not contain aliases (lyrixx)

fabpot · fabpot · commit 10a88cd2cdba · 2013-10-01T12:30:10.000+02:00
This PR was merged into the master branch. Discussion ---------- [Console] Throw an exception if the command does not contain aliases | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | license? | MIT It can only happend if the constructor has been overridden Commits ------- 7e5c901 [Console] Throw an exception if the command does not contain aliases
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -407,6 +407,10 @@ public function add(Command $command)
             return;
         }
 
+        if (null === $command->getAliases()) {
+            throw new \InvalidArgumentException(sprintf('You must call the parent constructor in "%s::__construct()"', get_class($command)));
+        }
+
         $this->commands[$command->getName()] = $command;
 
         foreach ($command->getAliases() as $alias) {
diff --git a/src/Symfony/Component/Console/Tests/ApplicationTest.php b/src/Symfony/Component/Console/Tests/ApplicationTest.php
@@ -40,6 +40,7 @@ public static function setUpBeforeClass()
         require_once self::$fixturesPath.'/Foo2Command.php';
         require_once self::$fixturesPath.'/Foo3Command.php';
         require_once self::$fixturesPath.'/Foo4Command.php';
+        require_once self::$fixturesPath.'/Foo5Command.php';
         require_once self::$fixturesPath.'/FoobarCommand.php';
     }
 
@@ -125,6 +126,16 @@ public function testAdd()
         $this->assertEquals(array($foo, $foo1), array($commands['foo:bar'], $commands['foo:bar1']), '->addCommands() registers an array of commands');
     }
 
+    /**
+     * @expectedException InvalidArgumentException
+     * @expectedExceptionMessage You must call the parent constructor in "Foo5Command::__construct()"
+     */
+    public function testAddCommandWithEmptyContructor()
+    {
+        $application = new Application();
+        $application->add($foo = new \Foo5Command());
+    }
+
     public function testHasGet()
     {
         $application = new Application();
diff --git a/src/Symfony/Component/Console/Tests/Fixtures/Foo5Command.php b/src/Symfony/Component/Console/Tests/Fixtures/Foo5Command.php
@@ -0,0 +1,10 @@
+<?php
+
+use Symfony\Component\Console\Command\Command;
+
+class Foo5Command extends Command
+{
+    public function __construct()
+    {
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -407,6 +407,10 @@ public function add(Command $command)`
`407`	`407`	`return;`
`408`	`408`	`}`
`409`	`409`
	`410`	`+ if (null === $command->getAliases()) {`
	`411`	`+ throw new \InvalidArgumentException(sprintf('You must call the parent constructor in "%s::__construct()"', get_class($command)));`
	`412`	`+ }`
	`413`	`+`
`410`	`414`	`$this->commands[$command->getName()] = $command;`
`411`	`415`
`412`	`416`	`foreach ($command->getAliases() as $alias) {`