[Translation] added detection for circular references when adding a fallback catalogue

fabpot · fabpot · commit 45b218e7c4cb · 2011-11-11T08:29:16.000+01:00
diff --git a/src/Symfony/Component/Translation/MessageCatalogue.php b/src/Symfony/Component/Translation/MessageCatalogue.php
@@ -26,6 +26,7 @@ class MessageCatalogue implements MessageCatalogueInterface
     private $locale;
     private $resources;
     private $fallbackCatalogue;
+    private $parent;
 
     /**
      * Constructor.
@@ -183,13 +184,32 @@ public function addCatalogue(MessageCatalogueInterface $catalogue)
      */
     public function addFallbackCatalogue(MessageCatalogueInterface $catalogue)
     {
+        // detect circular references
+        $c = $this;
+        do {
+            if ($c->getLocale() === $catalogue->getLocale()) {
+                throw new \LogicException(sprintf('Circular reference detected when adding a fallback catalogue for locale "%s".', $catalogue->getLocale()));
+            }
+        } while ($c = $c->getParent());
+
+        $catalogue->setParent($this);
         $this->fallbackCatalogue = $catalogue;
 
         foreach ($catalogue->getResources() as $resource) {
             $this->addResource($resource);
         }
     }
 
+    public function getParent()
+    {
+        return $this->parent;
+    }
+
+    public function setParent(self $parent)
+    {
+        $this->parent = $parent;
+    }
+
     /**
      * {@inheritdoc}
      *
diff --git a/tests/Symfony/Tests/Component/Translation/MessageCatalogTest.php b/tests/Symfony/Tests/Component/Translation/MessageCatalogTest.php
@@ -124,6 +124,18 @@ public function testAddFallbackCatalogue()
         $this->assertEquals(array($r, $r1), $catalogue->getResources());
     }
 
+    /**
+     * @expectedException LogicException
+     */
+    public function testAddFallbackCatalogueWithCircularReference()
+    {
+        $main = new MessageCatalogue('en_US');
+        $fallback = new MessageCatalogue('fr_FR');
+
+        $fallback->addFallbackCatalogue($main);
+        $main->addFallbackCatalogue($fallback);
+    }
+
     /**
      * @expectedException LogicException
      */
