8000 Update test suite to use PCOV to avoid segfault with Xdebug 3.4.2 by clue · Pull Request #205 · friends-of-reactphp/mysql · GitHub
[go: up one dir, main page]
Skip to content

Update test suite to use PCOV to avoid segfault with Xdebug 3.4.2 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionall 8000 y send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

Update test suite to use PCOV to avoid segfault with Xdebug 3.4.2 #205

merged 1 commit into from
May 20, 2025

Conversation

clue
Copy link
Contributor
@clue clue commented May 19, 2025 •
edited
Loading

This changeset updates the test suite to use PCOV instead of Xdebug on PHP 8+ to avoid a segfault with Xdebug 3.4.2 on PHP 8.1+ (https://bugs.xdebug.org/view.php?id=2332) as discussed in reactphp/socket#323.

Builds on top of clue/framework-x#278 and #204

@clue clue added this to the v0.7.0 milestone May 19, 2025
@clue clue requested a review from WyriHaximus May 19, 2025 19:25
@clue clue mentioned this pull request May 20, 2025
Merged
WyriHaximus
WyriHaximus approved these changes May 20, 2025
View reviewed changes
Copy link
Member
@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a chat with Derick recently about this, and he isn't expecting a fix anytime soon due to how hard the problem is. This a perfect long term solution until them

@WyriHaximus WyriHaximus merged commit 61ad81f into friends-of-reactphp:0.7.x May 20, 2025
14 checks passed
@clue clue deleted the pcov branch May 20, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@clue @WyriHaximus
0