fix: Fix crashes for FlutterRPScreenRecorder stop.

cloudwebrtc · cloudwebrtc · commit cde014dc325a · 2021-11-05T08:16:44.000+08:00
diff --git a/common/darwin/Classes/FlutterRPScreenRecorder.h b/common/darwin/Classes/FlutterRPScreenRecorder.h
@@ -4,6 +4,9 @@
 
 -(void)startCapture;
 
+// Stops the capture session asynchronously and notifies callback on completion.
+- (void)stopCaptureWithCompletionHandler:(nullable void (^)(void))completionHandler;
+
 -(void)stopCapture;
 
 @end
diff --git a/common/darwin/Classes/FlutterRPScreenRecorder.m b/common/darwin/Classes/FlutterRPScreenRecorder.m
@@ -54,6 +54,14 @@ -(void)stopCapture
     }
 }
 
+- (void)stopCaptureWithCompletionHandler:(nullable void (^)(void))completionHandler
+{
+    [self stopCapture];
+    if(completionHandler != nil) {
+        completionHandler();
+    }
+}
+
 -(void)handleSourceBuffer:(CMSampleBufferRef)sampleBuffer sampleType:(RPSampleBufferType)sampleType
 {
     if (CMSampleBufferGetNumSamples(sampleBuffer) != 1 || !CMSampleBufferIsValid(sampleBuffer) ||

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,14 @@ -(void)stopCapture`
`54`	`54`	`}`
`55`	`55`	`}`
`56`	`56`
	`57`	`+- (void)stopCaptureWithCompletionHandler:(nullable void (^)(void))completionHandler`
	`58`	`+{`
	`59`	`+ [self stopCapture];`
	`60`	`+ if(completionHandler != nil) {`
	`61`	`+ completionHandler();`
	`62`	`+ }`
	`63`	`+}`
	`64`	`+`
`57`	`65`	`-(void)handleSourceBuffer:(CMSampleBufferRef)sampleBuffer sampleType:(RPSampleBufferType)sampleType`
`58`	`66`	`{`
`59`	`67`	`if (CMSampleBufferGetNumSamples(sampleBuffer) != 1 \|\| !CMSampleBufferIsValid(sampleBuffer) \|\|`