8000 six lint · fossabot/firebase-admin-python@181d4c0 · GitHub
[go: up one dir, main page]

Skip to content

Commit 181d4c0

Browse files
committed
six lint
1 parent 425399a commit 181d4c0

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

firebase_admin/dynamic_links.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def __init__(self, event_stats):
8888
if not isinstance(event_stats, (list, tuple)):
8989
raise ValueError('Invalid data argument: {0}. Must be a list or tuple'
9090
.format(event_stats))
91-
if len(event_stats) > 0 and not isinstance(event_stats[0], EventStats):
91+
if event_stats and not isinstance(event_stats[0], EventStats):
9292
raise ValueError('Invalid data argument: elements of event stats must be' +
9393
' "EventStats", found{}'.format(type(event_stats[0])))
9494
self._stats = event_stats
@@ -114,10 +114,12 @@ def __init__(self, app):
114114

115115
def _populated_request(self, url, options):
116116
days = options.duration_days
117-
#pylint: disable-msg=too-many-arguments
118-
#this is due to six.urllib_parse incompatibility
119-
url_quoted = urllib_parse.quote(url, "")
120-
#pylint: enable-msg=too-many-arguments
117+
#pylint: disable=too-many-function-args
118+
# This is due to six.urllib_parse incompatibility
119+
#pylint: disable=redundant-keyword-arg
120+
url_quoted = urllib_parse.quote(url, safe="")
121+
#pylint: enable=redundant-keyword-arg
122+
#pylint: enable=too-many-function-args
121123
return self._links_request.format(url_quoted, days)
122124

123125
def get_stats(self, url, options):

0 commit comments

Comments
 (0)
0