8000 Issues/349 by wer-mathurin · Pull Request #350 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]

Skip to content

Issues/349 #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Issues/349 #350

merged 2 commits into from
Sep 18, 2020

Conversation

wer-mathurin
Copy link
Contributor

The bug was coming from that all StreamSubscription that was call after the renderer was dispose.

Note:
I tried adding a test, but since it basically always succeed.(see related bug) Maybe I'm not calling the test the right way !

@wer-mathurin wer-mathurin linked an issue Sep 17, 2020 that may be closed by this pull request
@cloudwebrtc
Copy link
Member

LGTM

@wer-mathurin wer-mathurin merged commit 89ed3c6 into master Sep 18, 2020
@wer-mathurin wer-mathurin deleted the issues/349 branch September 18, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error is thrown when disposinng the RTCVideoRenderer
2 participants
0