10000 Fixing multiple video renderers on the same HTML page for Flutter Web by leonidl · Pull Request #260 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]

Skip to content

Fixing multiple video renderers on the same HTML page for Flutter Web #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leonidl
Copy link
Contributor
@leonidl leonidl commented May 20, 2020

This commit fixes the case where multiple RTCVideoRenderer objects present on the same Flutter Web HTML page and where another object was using ui.platformViewRegistry.registerViewFactory() method.

This PR is supposed to fix issue #259 .

@cloudwebrtc
Copy link
Member

LGTM

@cloudwebrtc cloudwebrtc merged commit 9353964 into flutter-webrtc:master May 21, 2020
@leonidl leonidl deleted the flutter_web_multirenderer branch May 21, 2020 03:16
@leonidl leonidl restored the flutter_web_multirenderer branch May 21, 2020 03:16
cloudwebrtc added a commit that referenced this pull request Jul 4, 2020
Fixing multiple video renderers on the same HTML page for Flutter Web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0