8000 Support for Unified Plan. · Issue #99 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

Support for Unified Plan. #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cloudwebrtc opened this issue May 27, 2019 · 9 comments
Closed

Support for Unified Plan. #99

cloudwebrtc opened this issue May 27, 2019 · 9 comments
Assignees
@cloudwebrtc
Labels
🚀enhancement New feature or request work in progress work in progress

Comments

@cloudwebrtc
Copy link
Member

We need to add a series of interfaces, such as RtpTransceiver, RtpSender, RtpReceiver.
@cloudwebrtc cloudwebrtc changed the title Unified Plan Support. Support for Unified Plan. May 27, 2019
@cloudwebrtc cloudwebrtc self-assigned this May 28, 2019
@cloudwebrtc cloudwebrtc added the 🚀enhancement New feature or request label May 28, 2019
@rostopira
Copy link
Collaborator
rostopira commented May 31, 2019 •
edited
Loading

I have doubt, that regular developer would need to use them
Anyway, you can get them on android by just few lines in PeerConnectionObserver class

    @Override
    public void onTrack(RtpTransceiver transceiver) {
        final RtpSender rtpSender = transceiver.getSender();
        final RtpReceiver rtpReceiver = transceiver.getReceiver();
    }

Well, looks like, this method never called

@cloudwebrtc cloudwebrtc pinned this issue Jun 18, 2019
@cloudwebrtc cloudwebrtc mentioned this issue Jun 26, 2019
Closed
@cloudwebrtc
Copy link
Member Author

[WIP] https://github.com/cloudwebrtc/flutter-webrtc/tree/unified-plan

@cloudwebrtc cloudwebrtc added the work in progress work in progress label Aug 16, 2019
@cloudwebrtc cloudwebrtc changed the title Support for Unified Plan. [WIP]Support for Unified Plan. Aug 16, 2019
@rostopira
Copy link
Collaborator

Well, Flutter Web doesn't fit into unified plan at all due to missing dart:io package
I'm working on it in separate web folder, so resulting webrtc.dart will look like this:

export 'get_user_media.dart'
  if (dart.library.js) 'web/get_user_media.dart';
export 'media_stream_track.dart'
  if (dart.library.js) 'web/media_stream_track.dart';
export 'media_stream.dart'
  if (dart.library.js) 'web/media_stream.dart';
export 'rtc_data_channel.dart'
  if (dart.library.js) 'web/rtc_data_channel.dart';
export 'rtc_video_view.dart'
  if (dart.library.js) 'web/rtc_video_view.dart';
export 'rtc_ice_candidate.dart'
  if (dart.library.js) 'web/rtc_ice_candidate.dart';
export 'rtc_session_description.dart'
  if (dart.library.js) 'web/rtc_session_description.dart';
export 'rtc_peerconnection.dart'
  if (dart.library.js) 'web/rtc_peerconnection.dart';
export 'rtc_peerconnection_factory.dart'
  if (dart.library.js) 'web/rtc_peerconnection_factory.dart';
export 'rtc_stats_report.dart';
export 'media_recorder.dart'
  if (dart.library.js) 'web/media_recorder.dart';

I hope this won't hurt (=

@cloudwebrtc
Copy link
Member Author

No problem, let's make it work first. :)

@rostopira
Copy link
Collaborator

When you will merge this?
I wanna make Flutter Web PR API compatible to avoid compile time errors and merge conflicts

@cloudwebrtc
Copy link
Member Author

You can temporarily commit the changes to the branch and wait for me to complete the unified-plan work, then resolve the conflicts and merge them into the master.

@cloudwebrtc cloudwebrtc unpinned this issue Nov 14, 2019
@cloudwebrtc cloudwebrtc pinned this issue Nov 19, 2019
@ycherniavskyi
Copy link
Member

Just found rather useful related to this issue doc - “Unified Plan” Transition Guide (JavaScript) (it could be helpful for new contributors, such as me 😊, to understand what this issue is about).

8000
@cloudwebrtc cloudwebrtc mentioned this issue Aug 1, 2020
Closed
2 tasks
@shivanshtalwar0 shivanshtalwar0 mentioned this issue Oct 17, 2020
Closed
@cloudwebrtc
Copy link
Member Author

Now support Unified-Plan for iOS/Android/macOS.
#359
just need path the web plugin.

@cloudwebrtc cloudwebrtc changed the title [WIP]Support for Unified Plan. Support for Unified Plan. Oct 18, 2020
@cloudwebrtc
Copy link
Member Author

So close the issue and open a new one related to the web.

@cloudwebrtc cloudwebrtc unpinned this issue Oct 18, 2020
@cloudwebrtc cloudwebrtc moved this to Done in V2.0 Apr 13, 2023
@cloudwebrtc cloudwebrtc added this to V2.0 Apr 13, 2023
evdokimovs pushed a commit to evdokimovs/flutter-webrtc that referenced this issue Jun 6, 2024
@rogurotus @alexlapa
Upgrade flutter_rust_bridge to 1.62.1 version (flutter-webrtc#99)
595ef03 
Co-authored-by: alexlapa <lapa.alex@ex.ua>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cloudwebrtc cloudwebrtc

Labels
🚀enhancement New feature or request work in progress work in progress
Projects
V2.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ycherniavskyi @rostopira @cloudwebrtc
0