8000 MediaRecorder implementation for iOS · Issue #47 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

MediaRecorder implementation for iOS #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rostopira opened this issue Dec 28, 2018 · 13 comments
Closed

MediaRecorder implementation for iOS #47

rostopira opened this issue Dec 28, 2018 · 13 comments
Assignees
@rostopira
Labels
🚀enhancement New feature or request 🍎iOS 🦔rostopira Rostopira cares about this 😭stuck Not in WIP due to external reasons wontfix

Comments

@rostopira
Copy link
Collaborator

I can barely read Objective-C code, so help wanted)
@rostopira rostopira added the 😭help wanted Extra attention is needed label Dec 28, 2018
@aryzhov
Copy link
Contributor
aryzhov commented Jan 5, 2019

Could you outline the needed functionality and volume of work?

@rostopira
Copy link
Collaborator Author
< 8000 /h3>

For basic functionality we need capturing, encoding and muxing of video/audio track
Current dart api here: https://github.com/cloudwebrtc/flutter-webrtc/blob/master/lib/media_recorder.dart
Android implementation here: #46
It's originally based on original implementation of https://webrtc.googlesource.com/src/+/master/sdk/android/api/org/webrtc/VideoFileRenderer.java
Just added encoding, muxing and recording of local audio (unfortunately impossible to record any other AudioTrack due to current WebRTC implementation)
However, I've didn't find any hints for encoding or even writing to file in ios part of that repo

@rostopira rostopira self-assigned this Mar 28, 2019
@rostopira rostopira removed the 😭help wanted Extra attention is needed label Mar 28, 2019
@rostopira
Copy link
Collaborator Author
rostopira commented Mar 28, 2019 •
edited
Loading

I've made some progress with it, but currently busy with another project. Will push it to repo on next week

@rostopira
Copy link
Collaborator Author
rostopira commented Apr 5, 2019 •
edited
Loading

It's almost there!
If somebody wants to test it:

  flutter_webrtc:
    git:
      url: https://github.com/cloudwebrtc/flutter-webrtc
      ref: ios_recorder

UPD: currently only remote audio track is supported

@rostopira
Copy link
Collaborator Author

I were unable to find any solution for recording local audio track in WebRTC pod
If you are interested in this feature, star this issue: https://bugs.chromium.org/p/webrtc/issues/detail?id=10166

@aryzhov
Copy link
Contributor
aryzhov commented Apr 15, 2019 via email

@rostopira rostopira added 🚀enhancement New feature or request 😭stuck Not in WIP due to external reasons 🦔rostopira Rostopira cares about this labels Apr 24, 2019
@sam0829
Copy link
sam0829 commented Jun 14, 2020

@rostopira Hi, I am trying to record using the mentioned branch but the app crashes at
_audioSource->AddSink(_bridge); inside FlutterRTCAudioSink. The crash isn't revealing any information and just says EXC_BAD_ACCESS code 2. Did you face any such errors or do you know what's going on here?

@shivanshtalwar0 shivanshtalwar0 mentioned this issue Oct 2, 2020
8000
Closed
@stale
Copy link
stale bot commented Feb 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 7, 2021
@stale stale bot closed this as completed Feb 14, 2021
@bantunes22
Copy link
bantunes22 commented Mar 8, 2023 •
edited
Loading

@rostopira Did you finish this implementation? This issue is closed but when using the MediaRecorder::start(...), I'm getting this:

Unhandled Exception: MissingPluginException(No implementation found for method startRecordToFile on channel FlutterWebRTC.Method)

Is there anything I'm missing? I was digging into the code and on the iOS side I didn't find anything with the "startRecordToFile".

Using the lastest version available on the pub.dev.

On the pub.dev, there is a warning sign on the MediaRecorder, but no additional information about that warnings.

image

Is there anything I can do to help? I know Obj-C, so if there is no implementation yet and you can guide me to the proper documentation on this, I can try to help on this one.

I went to https://github.com/cloudwebrtc/flutter-webrtc but I was able to find the ios_recorder branch like you mentioned here:

#47 (comment)

Thanks

@rostopira
Copy link
Collaborator Author

@bantunes22 checkout PR #1189

It's very hacky, so I decided not to merge it.
I were going to create patch for WebRTC source itself, however still can't find time for that.

@bantunes22
Copy link

@bantunes22 checkout PR #1189

It's very hacky, so I decided not to merge it. I were going to create patch for WebRTC source itself, however still can't find time for that.

Thats awesome. I will have a look into it, and give some feedback. Thanks for the work, and let me know if ther is anything I can help.

@fantasyEthan
Copy link

Any idea of recording both video and audio on iOS on my iPhone? I also encountered No implementation found for method startRecordToFile on channel FlutterWebRTC.Methodand No implementation found for method stopRecordToFile on channel FlutterWebRTC.Method when running on iOS. How can I solve it or find a substitute way. Thanks

@patelnirav48
Copy link

@rostopira @bantunes22 Could you please help to tell when iOS recording support going to available?

evdokimovs pushed a commit to evdokimovs/flutter-webrtc that referenced this issue Jun 6, 2024
@alexlapa @rogurotus
Make AudioDeviceModule thread-safe (flutter-webrtc#47)
b6299c7 
Co-authored-by: rogurotus <rogurotus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rostopira rostopira

Labels
🚀enhancement New feature or request 🍎iOS 🦔rostopira Rostopira cares about this 😭stuck Not in WIP due to external reasons wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bantunes22 @aryzhov @patelnirav48 @sam0829 @rostopira @fantasyEthan
0