8000 Mandatory Audio Constraints · Issue #107 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content
8000

Mandatory Audio Constraints #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
clg236 opened this issue Jun 22, 2019 · 10 comments
Closed

Mandatory Audio Constraints #107

clg236 opened this issue Jun 22, 2019 · 10 comments
Labels
🚀enhancement New feature or request wontfix

Comments

@clg236
Copy link
clg236 commented Jun 22, 2019

Hi,

I've been trying to force audio constraints in my SDP, but am not sure if I'm formatting the contraints argument to navigator.getUserMedia correctly.

Currently I tried the following, but it doesn't seem to be working in the SDP:

"video: false,
"audio": {
          "exact": {
            "channelCount": 2,
            "echoCancellation": false,
            "autoGainControl": false,
            "noiseSuppression": false,
            "latency": 50,
            "sampleRate": 48,
            "sampleSize": 16,
          }
      }
@cloudwebrtc
Copy link
Member

These parameters belong to the WebRTC private constraint parameter and need to be available at Android:
https://github.com/cloudwebrtc/flutter-webrtc/blob/master/android/src/main/java/com/cloudwebrtc/webrtc/FlutterWebRTCPlugin.java#L547
And
iOS:
https://github.com/cloudwebrtc/flutter-webrtc/blob/master/ios/Classes/FlutterWebRTCPlugin.m#L647 additional parameter conversion

@cloudwebrtc
8000 Copy link
Member

These parameters seem to be less common, and if you are interested in adding, we would be happy to accept a PR.

@clg236
Copy link
Author
clg236 commented Jun 27, 2019

Cool. I’d love to work on a PR. Any advice on where to start? (I am am amateur)

@cloudwebrtc
Copy link
Member

@clg236
The set of constraints that can be used in the webrtc native library is in this file. media_constraints.h.
You can try to test these parameters and apply them to the flutter-webrtc plugin via the objc/java interface.

@clg236
Copy link
Author
clg236 commented Jul 8, 2019 via email •
edited
Loading

@rostopira
Copy link
Collaborator

@clg236 On android you can set this parameters on JavaAudioDeviceModule directly
https://github.com/cloudwebrtc/flutter-webrtc/blob/master/android/src/main/java/com/cloudwebrtc/webrtc/FlutterWebRTCPlugin.java#L113
Modify source and forget about it, I have high doubts that anyone else would ever need this

@rostopira rostopira added the 🚀enhancement New feature or request label Aug 22, 2019
@carloselborges
Copy link
carloselborges commented Sep 22, 2020 •
edited
Loading

@clg236 and @cloudwebrtc
Is this already implemented?
Is there a place to set latency, or disable other audio settings, like noiseSupression?

@wer-mathurin
Copy link
Contributor

If you were using the web implementation, any constraints where not taken into account before this PR.

@carloselborges : Let us know if you were using the native or web implementation. So we can track it properly.

@carloselborges
Copy link

Hello @wer-mathurin, I'm working native.
I just want to know if thats is available on native iOS and Android.
On web, I've noticed that it's supported by some browsers...

@stale
Copy link
stale bot commented Feb 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 7, 2021
@stale stale bot closed this as completed Feb 14, 2021
@cloudwebrtc cloudwebrtc moved this to Done in V2.0 Apr 13, 2023
@cloudwebrtc cloudwebrtc added this to V2.0 Apr 13, 2023
evdokimovs pushed a commit to evdokimovs/flutter-webrtc that referenced this issue Jun 6, 2024
@dependabot @tyranron
Fix actions/setup-java version to v3 (flutter-webrtc#107)
b60804c 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kai Ren <tyranron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀enhancement New feature or request wontfix
Projects
V2.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@clg236 @carloselborges @rostopira @cloudwebrtc @wer-mathurin
0