8000 Comparing v1.2.0...main · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-webrtc/flutter-webrtc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.0
Choose a base ref
...
head repository: flutter-webrtc/flutter-webrtc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Oct 3, 2025

  1. fix: clip hard edge on web's rtc_video_view (#1936)

    This PR fixes an issue where iOS Safari video box renders would exceed
    the boundaries set by the
    `RTCVideoViewObjectFit.RTCVideoViewObjectFitContain` and
    `RTCVideoViewObjectFit.RTCVideoViewObjectFitCover` guidelines.
    
    In the following examples (iOS Safari), I have specified the following:
    ```dart
    rtc.RTCVideoView(
      _renderer! as rtc.RTCVideoRenderer,
      mirror: true,
      filterQuality: FilterQuality.medium,
      objectFit: RTCVideoViewObjectFit.RTCVideoViewObjectFitCover,
    );
    ```
    
    **Before this PR**
    ![IMG_0061
    Medium](https://github.com/user-attachments/assets/cd4c5e3a-f915-4c00-a559-71163b384b75)
    ![IMG_0062
    Medium](https://github.com/user-attachments/assets/21077d4c-94fa-476a-9486-8783f6f919e7)
    
    **After this PR**
    ![IMG_0059
    Medium](https://github.com/user-attachments/assets/b8050c80-9739-412c-839c-d25cf4d08cb6)
    ![IMG_0060
    Medium](https://github.com/user-attachments/assets/ec212d4b-e763-480e-95cd-5087006ceb28)
    kNoAPP authored Oct 3, 2025
    Configuration menu
    Copy the full SHA
    f358f76 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2025

  1. Fix: fix Android chrome mobile not rendering html <video> element (#1938

    )
    
    There is an issue in chrome mobile where, if the video element tag is
    outside of the visible viewport, the video won't be rendered (will
    appear as black).
    
    That can happen if the added video tag just happens to go in the bottom
    of a body, and whatever relative elements exists before pushes it
    outside of the viewport boundary
    
    
    https://github.com/user-attachments/assets/a0ef4506-7642-4fbd-a68e-dfc0d3798d5c
    
    
    This fix forces the position html video element (that is already an
    absoltue element) to be on the top left so it stays on screen and thus
    is rendered by chrome mobile not depending of the contents of the html
    itself.
    
    ---
    
    I've tested this and it only happens specifically in Androrid-Chrome
    combo
    
    cc @kNoAPP that helped find where in the code the html element was
    created
    dganzella authored Oct 7, 2025
    Configuration menu
    Copy the full SHA
    51ff309 View commit details
    Browse the repository at this point in the history
Loading
0