8000 revert destructive changes. · flutter-webrtc/flutter-webrtc@d33dd89 · GitHub
[go: up one dir, main page]

Skip to content

Commit d33dd89

Browse files
committed
revert destructive changes.
1 parent eecab98 commit d33dd89

File tree

4 files changed

+20
-9
lines changed

4 files changed

+20
-9
lines changed

example/lib/src/get_user_media_sample.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ class _GetUserMediaSampleState extends State<GetUserMediaSample> {
125125
if (await file.exists()) {
126126
await file.delete();
127127
}
128-
_mediaRecorder = MediaRecorder();
128+
_mediaRecorder = MediaRecorder(albumName: 'FlutterWebRTC');
129129
setState(() {});
130130

131131
final videoTrack = _localStream!
@@ -145,7 +145,7 @@ class _GetUserMediaSampleState extends State<GetUserMediaSample> {
145145
}
146146

147147
// album name works only for android, for ios use gallerySaver
148-
await _mediaRecorder?.stop(albumName: 'FlutterWebRTC');
148+
await _mediaRecorder?.stop();
149149
setState(() {
150150
_mediaRecorder = null;
151151
});

lib/src/media_recorder.dart

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,17 @@
1+
import 'package:flutter/foundation.dart';
2+
13
import 'package:webrtc_interface/webrtc_interface.dart' as rtc;
24

35
import '../flutter_webrtc.dart';
6+
import 'native/media_recorder_impl.dart' show MediaRecorderNative;
47

58
class MediaRecorder extends rtc.MediaRecorder {
6-
MediaRecorder() : _delegate = mediaRecorder();
9+
MediaRecorder({
10+
String? albumName,
11+
}) : _delegate = (kIsWeb || kIsWasm)
12+
? mediaRecorder()
13+
: MediaRecorderNative(albumName: albumName);
14+
715
final rtc.MediaRecorder _delegate;
816

917
@override
@@ -21,8 +29,7 @@ class MediaRecorder extends rtc.MediaRecorder {
2129
}
2230

2331
@override
24-
Future stop({String? albumName}) =>
25-
_delegate.stop(albumName: albumName ?? "FlutterWebRtc");
32+
Future stop() => _delegate.stop();
2633

2734
@override
2835
void startWeb(

lib/src/native/media_recorder_impl.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,13 @@ import 'media_stream_track_impl.dart';
77
import 'utils.dart';
88

99
class MediaRecorderNative extends MediaRecorder {
10+
MediaRecorderNative({
11+
String? albumName = 'FlutterWebRTC',
12+
}) : _albumName = albumName;
1013
static final _random = Random();
1114
final _recorderId = _random.nextInt(0x7FFFFFFF);
1215
var _isStarted = false;
16+
final String? _albumName;
1317

1418
@override
1519
Future<void> start(
@@ -42,13 +46,13 @@ class MediaRecorderNative extends MediaRecorder {
4246
}
4347

4448
@override
45-
Future<dynamic> stop({String? albumName}) async {
49+
Future<dynamic> stop() async {
4650
if (!_isStarted) {
4751
throw "Media recorder not started!";
4852
}
4953
return await WebRTC.invokeMethod('stopRecordToFile', {
5054
'recorderId': _recorderId,
51-
'albumName': albumName,
55+
'albumName': _albumName,
5256
});
5357
}
5458
}

pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ environment:
88

99
dependencies:
1010
collection: ^1.17.0
11-
dart_webrtc: ^1.5.4
11+
dart_webrtc: ^1.5.3+hotfix.2
1212
flutter:
1313
sdk: flutter
1414
path_provider: ^2.0.2
1515
web: ^1.0.0
16-
webrtc_interface: ^1.2.3
16+
webrtc_interface: ^1.2.2+hotfix.2
1717

1818
dev_dependencies:
1919
flutter_test:

0 commit comments

Comments
 (0)
0