Fix adding track to stream igal committed (#413)

igala · igal · web-flow · commit 8cf0cd22f763 · 2020-11-15T09:51:52.000+08:00
The method tried to find the tracks in the localTRacks map instead of parsing peerconnection remote track

Co-authored-by: igal &lt;igal38@gmail.com&gt;
diff --git a/android/src/main/java/com/cloudwebrtc/webrtc/MethodCallHandlerImpl.java b/android/src/main/java/com/cloudwebrtc/webrtc/MethodCallHandlerImpl.java
@@ -1129,18 +1129,18 @@ public void mediaStreamTrackSetVolume(final String id, final double volume) {
   public void mediaStreamAddTrack(final String streaemId, final String trackId, Result result) {
     MediaStream mediaStream = localStreams.get(streaemId);
     if (mediaStream != null) {
-      MediaStreamTrack track = localTracks.get(trackId);
+      MediaStreamTrack track = getTrackForId(trackId);//localTracks.get(trackId);
       if (track != null) {
         if (track.kind().equals("audio")) {
           mediaStream.addTrack((AudioTrack) track);
         } else if (track.kind().equals("video")) {
           mediaStream.addTrack((VideoTrack) track);
         }
       } else {
-        resultError("mediaStreamAddTrack", "mediaStreamAddTrack() track [" + trackId + "] is null", result);
+        resultError("mediaStreamAddTrack", "mediaStreamAddTrack() tracking [" + trackId + "] is null", result);
       }
     } else {
-      resultError("mediaStreamAddTrack", "mediaStreamAddTrack() track [" + trackId + "] is null", result);
+      resultError("mediaStreamAddTrack", "mediaStreamAddTrack() streamId [" + streaemId + "] is null", result);
     }
     result.success(null);
   }

Original file line number	Diff line number	Diff line change
`@@ -1129,18 +1129,18 @@ public void mediaStreamTrackSetVolume(final String id, final double volume) {`
`1129`	`1129`	`public void mediaStreamAddTrack(final String streaemId, final String trackId, Result result) {`
`1130`	`1130`	`MediaStream mediaStream = localStreams.get(streaemId);`
`1131`	`1131`	`if (mediaStream != null) {`
`1132`		`- MediaStreamTrack track = localTracks.get(trackId);`
	`1132`	`+ MediaStreamTrack track = getTrackForId(trackId);//localTracks.get(trackId);`
`1133`	`1133`	`if (track != null) {`
`1134`	`1134`	`if (track.kind().equals("audio")) {`
`1135`	`1135`	`mediaStream.addTrack((AudioTrack) track);`
`1136`	`1136`	`} else if (track.kind().equals("video")) {`
`1137`	`1137`	`mediaStream.addTrack((VideoTrack) track);`
`1138`	`1138`	`}`
`1139`	`1139`	`} else {`
`1140`		`- resultError("mediaStreamAddTrack", "mediaStreamAddTrack() track [" + trackId + "] is null", result);`
	`1140`	`+ resultError("mediaStreamAddTrack", "mediaStreamAddTrack() tracking [" + trackId + "] is null", result);`
`1141`	`1141`	`}`
`1142`	`1142`	`} else {`
`1143`		`- resultError("mediaStreamAddTrack", "mediaStreamAddTrack() track [" + trackId + "] is null", result);`
	`1143`	`+ resultError("mediaStreamAddTrack", "mediaStreamAddTrack() streamId [" + streaemId + "] is null", result);`
`1144`	`1144`	`}`
`1145`	`1145`	`result.success(null);`
`1146`	`1146`	`}`