Use proper state lifecycle method for nulling renderer state changed handler

ycherniavskyi · ycherniavskyi · commit 1533df9d3a18 · 2020-04-03T23:28:10.000+03:00
Currently used `deactivate` method can be called many times during a state lifecycle.
(For example, it called several times during animation, which occurs when Scaffold with
RTCVideoView is shown with regular route push animation.)
Actually, subclasses should override `deactivate` method to clean up any links between
this object and other elements in the tree (e.g. if you have provided an ancestor with
a pointer to a descendant's RenderObject).
diff --git a/lib/rtc_video_view.dart b/lib/rtc_video_view.dart
@@ -128,8 +128,8 @@ class _RTCVideoViewState extends State<RTCVideoView> {
   }
 
   @override
-  void deactivate() {
-    super.deactivate();
+  void dispose() {
+    super.dispose();
     widget._renderer.onStateChanged = null;
   }
 
diff --git a/lib/web/rtc_video_view.dart b/lib/web/rtc_video_view.dart
@@ -171,8 +171,8 @@ class _RTCVideoViewState extends State<RTCVideoView> {
   }
 
   @override
-  void deactivate() {
-    super.deactivate();
+  void dispose() {
+    super.dispose();
     _renderer.onStateChanged = null;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -128,8 +128,8 @@ class _RTCVideoViewState extends State<RTCVideoView> {`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`@override`
`131`		`- void deactivate() {`
`132`		`- super.deactivate();`
	`131`	`+ void dispose() {`
	`132`	`+ super.dispose();`
`133`	`133`	`widget._renderer.onStateChanged = null;`
`134`	`134`	`}`
`135`	`135`
Original file line number	Diff line number	Diff line change
`@@ -171,8 +171,8 @@ class _RTCVideoViewState extends State<RTCVideoView> {`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`@override`
`174`		`- void deactivate() {`
`175`		`- super.deactivate();`
	`174`	`+ void dispose() {`
	`175`	`+ super.dispose();`
`176`	`176`	`_renderer.onStateChanged = null;`
`177`	`177`	`}`
`178`	`178`